feat(github-agent): add @gittensory ask command with cited contribution-context output#262
Conversation
|
Related Knowledge 2 documents with suggested updates are ready for review. gittensory For MaintainersView Suggested Changes@@ -350,6 +350,16 @@
@gittensory help
```
+##### `@gittensory ask <question>`
+
+Answers contribution-quality questions from connected cached sources with citations and freshness notes. Supports contribution-quality Q&A with source citations from connected cached sources including GitHub issues/PRs/recent merges/checks, signal snapshots, focus manifest, and upstream ruleset status. Answer scope is limited to contribution quality and repository policy. Sources are cited with freshness and public-boundary redaction.
+
+**Example:**
+
+```
+@gittensory ask what are the coding standards for this repo?
+```
+
##### `@gittensory preflight`
Summarizes PR hygiene and validation readiness. Shows up to 3 relevant actions from preflight analysis, including linked context, branch freshness, and validation status [[48]](https://github.com/JSONbored/gittensory/blob/1e7506f4c5226d0b9b5da8fcd219309d84bacfcd/src/github/commands.ts#L165-L180).✅ Accepted Gittensory ArchitectureView Suggested Changes@@ -80,7 +80,7 @@
- `backfill.ts`: Syncs repos, issues, and PRs from GitHub's REST API
- `webhook.ts`: Handles incoming GitHub webhook events
- `app.ts`: Manages GitHub App installation and token generation
-- `commands.ts`: Parses @gittensory mention commands (help, preflight, blockers, duplicate-check, miner-context, next-action, reviewability, repo-fit, packet, queue-summary, review-now, needs-author, confirmed-miners, duplicate-clusters). The last five commands are maintainer-only queue digest commands that build from cached GitHub metadata rather than agent runs [[25]](https://github.com/JSONbored/gittensory/pull/190)
+- `commands.ts`: Parses @gittensory mention commands (help, ask, preflight, blockers, duplicate-check, miner-context, next-action, reviewability, repo-fit, packet, queue-summary, review-now, needs-author, confirmed-miners, duplicate-clusters). The last five commands are maintainer-only queue digest commands that build from cached GitHub metadata rather than agent runs [[25]](https://github.com/JSONbored/gittensory/pull/190)
- `comments.ts`: Posts public-safe intelligence comments to PRs/issues
- `labels.ts`: Applies Gittensor labels based on repository settings
- `public.ts`: Fetches public GitHub user profiles✅ Accepted |
af4d3df to
355487a
Compare
JSONbored
left a comment
There was a problem hiding this comment.
@claytonlin1110 the @gittensory ask command is a good product direction, and the public-surface sanitizer coverage is the right constraint.
A few notes:
- Parsing the question text and threading it into the command objective is useful.
- The command is still behaviorally weaker than the PR title/body promise.
- The current output mostly repackages agent actions and generic source notes; it does not provide concrete cited source references.
- The refresh path for
askcurrently rendersNext-action snapshot refresh, which is the wrong command framing.
Required changes:
- Make
askoutput concrete contribution-context source references, or narrow the PR/body copy so it does not claim cited output. - Fix the refresh path so
@gittensory askuses ask/contribution-context refresh wording. - Add tests that assert source/freshness details are present for successful
askoutput and that refresh output uses theasklabel.
Validation expected:
- Re-run
validate, with focused coverage for parser, command rendering, authorization, and public-output sanitizer paths.
|
@JSONbored updated. please review |
80c7f1e to
ff6be88
Compare
e804f97 to
be11852
Compare
JSONbored
left a comment
There was a problem hiding this comment.
@claytonlin1110 this is closer, but the ask command still needs stronger cited-source behavior.
Required changes:
- Ensure answers include concrete cited source references, not just generic snapshot language.
- Complete the validation matrix or explain any skipped checks.
- Keep public output sanitized and low-noise.
Validation expected:
- npm run test:ci
- Targeted GitHub command/output tests for cited ask responses
e5ed417 to
662d6d2
Compare
@JSONbored Updated |
JSONbored
left a comment
There was a problem hiding this comment.
@claytonlin1110 this still needs stronger cited-source behavior.
A few notes:
- Adding
@gittensory askis the right product direction. - The parser and sanitizer coverage are useful.
- The title/body promise is still stronger than the current output unless concrete source references are included.
Required changes:
- Make successful ask responses include concrete cited source/freshness references.
- Fix any refresh wording so it reads as ask/contribution-context behavior, not generic next-action refresh.
- Complete the validation matrix or explain skipped checks precisely.
Validation expected:
- Full
npm run test:ci - Focused GitHub command rendering tests for cited ask output
3410973 to
adb107e
Compare
Fixed |
Summary
@gittensory ask <question>to support contribution-quality Q&A from connected cached sources with source/freshness notes.Closes feat(github-agent): add repo and docs context Q&A from connected sources #142
Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
vitest run test/unit/github-commands.test.tsvitest run test/unit/queue.test.tsvitest run test/unit/product-usage.test.ts test/unit/openapi.test.ts test/integration/api.test.tsSafety
Notes
src/github/commands.tssrc/queue/processors.tstest/unit/github-commands.test.ts