Removed Tailwind, Theme Handling, Cleaned up codebase - #2
Merged
Conversation
Dark Mode toggle has been switched to ThemeToggle. Perhaps in the future we can add more than just light and dark mode, and now it is extensible. Refactored the Leaderboard page to strictly use CSS classes instead of Tailwind preset. colors.css is slowly being populated. It will support all of the color variables and how they should appear based on theme. Next step is to continue to remove Tailwind while making all of the CSS depend on those color variables.
JManion32
changed the title
I should've committed this several weeks ago.
Centralizes the time to switch between themes to a single variable for CSS classes. This is extremeley messy so I am going to jump to another branch to create infrastructure for working on the UI without having to build containers.
Much work still to do, and once tailwind is removed, we need to smoothen out the light/dark mode transitions, and make sure the font and transition vars are set from colors.css.
Removed all Tailwind in favor of CSS classes, and did some small refactoring of components
Ready for merge after testing with a real API and passing CI
JManion32
changed the title
JManion32
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOOD BYE AND GOOD RIDDANCE, TAILWIND!
It was helpful for scaling fast, but slowly became a maintainability nightmare. In the past year, I have come to appreciate the elegance of using normal CSS classes and variables. Now, Speed Roulette uses that only, and the Tailwind dependency is GONE!
Dark Mode toggle has been switched to ThemeToggle. Perhaps in the future we can add more than just light and dark mode, and now it is extensible.
Overall, the site feels smoother, with several small cleanups as a result of a few new shared components and CSS classes. I will dive further into the layout of my components and hooks in future PRs, as they are quite messy right now.