Changes to logLevels#251
Open
hmenzagh wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 24 24
Lines 2805 2805
=======================================
Hits 2286 2286
Misses 519 519 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple pull request to change
logLevels(This PR is kind of opinionated).Changes:
INFOlevel (changes made to the .md and the seed file too)INFOlevel tooNOTElevelThis is to comply with le descriptions of
INFOas being minor informations andNOTEas being verbose.An argument could be made that the route creations should be on the
NOTElevel but since it only concerns a single batch output at the beginning of the execution and that this information can be useful to ensure that everything went well without being too verbose I believe theINFOlevel is appropriate.Feel free to ask me to change my PR if you don't agree !