Skip to content

Changes to logLevels#251

Open
hmenzagh wants to merge 8 commits into
JKHeadley:masterfrom
hmenzagh:pull-request-without-esm
Open

Changes to logLevels#251
hmenzagh wants to merge 8 commits into
JKHeadley:masterfrom
hmenzagh:pull-request-without-esm

Conversation

@hmenzagh
Copy link
Copy Markdown
Contributor

@hmenzagh hmenzagh commented Jul 16, 2020

Simple pull request to change logLevels (This PR is kind of opinionated).
Changes:

  • Route creations are now on the INFO level (changes made to the .md and the seed file too)
  • Request are on the INFO level too
  • Request results are on the NOTE level

This is to comply with le descriptions of INFO as being minor informations and NOTE as being verbose.

An argument could be made that the route creations should be on the NOTE level but since it only concerns a single batch output at the beginning of the execution and that this information can be useful to ensure that everything went well without being too verbose I believe the INFO level is appropriate.

Feel free to ask me to change my PR if you don't agree !

@hmenzagh hmenzagh changed the title Pull request without esm Changes to logLeves Jul 16, 2020
@hmenzagh hmenzagh changed the title Changes to logLeves Changes to logLevels Jul 16, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2020

Codecov Report

❌ Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.49%. Comparing base (a911ade) to head (6fdb815).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
utilities/rest-helper-factory.js 0.00% 11 Missing ⚠️
utilities/handler-helper.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          24       24           
  Lines        2805     2805           
=======================================
  Hits         2286     2286           
  Misses        519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant