Repository navigation
feat(v1.6.7): withdrawal record filters and spot ticker snippet - #6
Merged
Merged
Conversation
1.6.7 - getWithdrawalRecords accepts withdraw_id and withdraw_order_id - JSDoc on submitWithdrawal and submitMainSubTransfer: on HTTP 5xx or SERVER_ERROR, check withdrawal records or getTransferStatus(client_order_id) before resending - README: 3-line spot.tickers snippet near the top (reconnect, heartbeat, resubscribe) Skipped: Crossex 4xx idempotency note, still waiting on a staff answer. Co-authored-by: Jerko J <JJ-Cro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate withdrawal list filters and a short public ticker example at the top of the README. Version 1.6.7. Branched from upstream master
0db35aeafter sieblyio#148 and sieblyio#149.Changelog
getWithdrawalRecordsacceptswithdraw_idandwithdraw_order_idonGET /wallet/withdrawals.withdraw_idreturns that one record and disables the time filter. Deposit queries stay on the shared params type.submitWithdrawalandsubmitMainSubTransfer: on HTTP 5xx orSERVER_ERROR, the call may still have been accepted. CheckgetWithdrawalRecords({ withdraw_order_id })orgetTransferStatus({ client_order_id })before sending it again.spot.tickersWebsocketClientsnippet near the top. The SDK handles reconnect, heartbeat, and resubscribe.Skipped: Crossex 4xx idempotency note, still waiting on a staff answer.
Checks
npx eslint srccleannpx tsc -p test/tsconfig.test.json --noEmitcleannpm run buildcleanwsStore9 passed,public.test.ts2 passedprivate.test.tsnot run (needs API keys)