refactor(ui): align error_detail panel with design tokens#59
Merged
Conversation
- Replace text-[11px] with text-xs (project scale) - Replace bg-white/60 dark:bg-black/30 with bg-gray-100 dark:bg-gray-800 (project monospace surface) - Replace 6× opacity-60 labels with text-gray-500 dark:text-gray-400 (project muted-text token) - Add focus:outline-none focus:ring-1 focus:ring-blue-500 rounded-sm to <summary> (existing project focus pattern) No behavior change. Pure design-system alignment to prevent off-scale tokens from drifting elsewhere via copy-paste. Refs #57 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns the History failed-job error_detail <details> panel styling with existing Tailwind design tokens and established template conventions, addressing the design-token drift introduced in PR #56 (issue #57).
Changes:
- Replace off-scale font size (
text-[11px]) with tokenizedtext-xs. - Swap ad-hoc translucent surface (
bg-white/60 dark:bg-black/30) for the project’s common monospace surface (bg-gray-100 dark:bg-gray-800). - Replace
opacity-60labels with the repo’s muted-text token (text-gray-500 dark:text-gray-400) and add an explicit focus ring to<summary>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
Summary
src/templates/partials/job_status.html) introduced by PR feat(observability): preserve raw API error in error_detail field (#54) #56.Implementation notes
text-[11px] leading-relaxed→text-xs leading-relaxedtext-xs(12px) is used 4× in this same template. Removes the only off-scaletext-[<n>px]value insrc/templates/.bg-white/60 dark:bg-black/30→bg-gray-100 dark:bg-gray-800bg-red-100/60 dark:bg-red-950/40, butbg-red-950/bg-yellow-950have zero usage in the codebase (red/yellow dark surfaces stop at-900/30). Used the cited monospace-block convention instead, which avoids introducing a new color stop.opacity-60→text-gray-500 dark:text-gray-400replace_all. The project's muted-text token has 65 cross-template occurrences across 7 files.<summary>gainedrounded-sm hover:underline focus:outline-none focus:ring-1 focus:ring-blue-500focus-visible:ring-2 focus-visible:ring-current/50, butfocus-visible:has zero usage insrc/templates/(16 sites use plainfocus:). Used the existing pattern fromsrt_editor.html:211instead. Therounded-smis required because the focus ring is implemented asbox-shadowand follows the element'sborder-radius— verified empirically.A separate follow-up issue should be filed for project-wide
focus-visibleadoption (16 sites, single PR, with proper visual regression). That's a coherent accessibility upgrade that deserves its own scope, not a smuggled exception inside a token-cleanup PR.Verification
ruff check src/ tests/— All checks passedruff format --check src/ tests/— 56 files already formattedpytest -m "not e2e"— 228 passed, 6 deselected, 2.02sDATA_DIR=/tmp/voicesrt-review/datainstance (production DB untouched)bg-gray-100→rgb(243,244,246)/bg-gray-800→rgb(31,41,55)text-gray-500→rgb(107,114,128)/text-gray-400→rgb(156,163,175)12px(text-xs, no longer the previous 11px arbitrary value)box-shadow: rgb(59,130,246) 0 0 0 1px+border-radius: 2px(the rounded-sm is load-bearing — without it the box-shadow ring would have sharp 0-radius corners)詳細を表示renders correctlyPre-PR review summary
/claude-c-suite:ask→ CDO (no escalation), confirmed by/claude-c-suite:dx-lead/claude-c-suite:auditis a plugin-internal release gate for the C-Suite plugin's own command files; does not apply to this repo)Full reviews are saved in the plugin cache:
~/.claude/cache/gh-issue-driven/57-feat-ui-history-align-error-detail-panel-with.gate1.md~/.claude/cache/gh-issue-driven/57-feat-ui-history-align-error-detail-panel-with.gate2.md🤖 Generated via /gh-issue-driven:ship