-
Notifications
You must be signed in to change notification settings - Fork 0
og 이미지, 메타데이터 추가 #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
og 이미지, 메타데이터 추가 #267
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { MetadataRoute } from "next" | ||
|
|
||
| export default function robots(): MetadataRoute.Robots { | ||
| return { | ||
| rules: [ | ||
| { | ||
| userAgent: "*", | ||
| allow: "/", | ||
| disallow: ["/admin"], | ||
| }, | ||
| ], | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import type { MetadataRoute } from "next" | ||
|
|
||
| export default function sitemap(): MetadataRoute.Sitemap { | ||
| return [ | ||
| { | ||
| url: "https://re-creation.vercel.app", | ||
| lastModified: new Date(), | ||
| }, | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getGameDetail실패 시 에러 처리가 필요합니다.getGameDetail(params.gameId)호출이 실패할 경우(존재하지 않는 게임, 네트워크 오류 등) 메타데이터 생성이 실패하여 페이지 렌더링에 영향을 줄 수 있습니다. try-catch를 통한 에러 처리 또는 fallback 메타데이터 반환을 권장합니다.🛡️ 에러 처리 추가 제안
export async function generateMetadata({ params, }: { params: { gameId: string } }) { - const { data: game } = await getGameDetail(params.gameId) - return { - title: `${game.gameTitle} - Re:creation`, - robots: { - index: false, - follow: false, - }, - openGraph: { - title: game.gameTitle, - type: "website", - locale: "ko_KR", - images: [ - { - url: `/og/og-${params.gameId}.png`, - width: 1200, - height: 630, - alt: game.gameTitle, - type: "image/png", - }, - ], - }, + try { + const { data: game } = await getGameDetail(params.gameId) + return { + title: `${game.gameTitle} - Re:creation`, + robots: { + index: false, + follow: false, + }, + openGraph: { + title: game.gameTitle, + type: "website", + locale: "ko_KR", + images: [ + { + url: `/og/og-${params.gameId}.png`, + width: 1200, + height: 630, + alt: game.gameTitle, + type: "image/png", + }, + ], + }, + } + } catch { + return { + title: "Re:creation", + robots: { + index: false, + follow: false, + }, + } } }