Reference files to test ObsSpace::reduce and ObsSpace::append for OSDF#231
Open
lewisn-met wants to merge 7 commits intodevelopfrom
Open
Reference files to test ObsSpace::reduce and ObsSpace::append for OSDF#231lewisn-met wants to merge 7 commits intodevelopfrom
lewisn-met wants to merge 7 commits intodevelopfrom
Conversation
lewisn-met
requested review from
fmahebert,
mikecooke77,
rajichidamb,
srherbener and
svahl991
lewisn-met
added
coordinate merge
mikecooke77
approved these changes
Jan 26, 2026
lewisn-met
changed the title
Contributor
Author
|
Added reference files for testing ObsSpace::append to this PR, since they have the same requirements. |
svahl991
approved these changes
Feb 2, 2026
Contributor
Author
|
As per the discussion in JCSDA-internal/ioda/pull/1684, this data update may not be necessary (as it duplicates reference files already used for ObsGroup tests). Will test once the OSDF writer is in place and close the PR if this is the case. |
Collaborator
Sounds great! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds reference files to test the reduce functionality of the ObsSpace, when the ObsSpace is OSDF based.
Issue(s) addressed
Resolves JCSDA-internal/ioda#1605
Dependencies
Impact
N/A (OSDF functionality not currently implemented)
Checklist