docs(spec): add architecture spec suite and ADR 0001 for Google Cloud Document Translation - #74
Merged
Merged
Conversation
… translation - Add spec/design.md with book-scale GCP batch translation architecture - Add spec/requirements.md with BDD Gherkin scenarios and traceability matrix - Add spec/tasks.md with 4 parallel/sequential execution tracks and TDD criteria - Add docs/adr/0001-migrate-to-google-cloud-document-translation.md - Update README.md with target architecture flowchart and spec links
…n review - Add .greptile/instructions.md with project mission and Dolphin OCR deprecation policy - Add .greptile/rules.md with blocking gates, severity scoring, and glossary constraints - Add .greptile/context.md with architectural context and specification references
Owner
Author
|
@greptile review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Move design.md, requirements.md, tasks.md into spec/gcp-migration/ - Update relative and markdown links across README.md, ADR 0001, and .greptile/context.md
Owner
Author
|
@greptile review |
- Update README architecture diagram to show batchTranslateDocument (GCS) - Fix LRO progress contract across specs (translated_pages, SUCCEEDED state) - Replace absolute local worktree links with repository-relative paths
Owner
Author
|
@greptile review |
…nstitution - Establish GCP Document Translation and GCS async batch as book-scale default - Define official Translation v3 LRO contract (translated_pages, SUCCEEDED) - Document Dual-Tier Glossary Synchronization standards - Specify deprecation deny list (Dolphin OCR, canvas overlays, absolute links) - Enforce topical subdirectory organization for spec files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architectural Specification & Decision Record (ADR 0001)
Summary
This PR introduces the formal technical specification suite (following the
/spec-creatorKiro/Blackwall standard) and Architecture Decision Record (ADR 0001) defining PhenomenalLayout's strategic migration to Google Cloud Document Translation API (Cloud Translation - Advanced v3).Key Architectural Shifts
batchTranslateDocumentvia Google Cloud Storage (GCS) as the primary, default translation pipeline for 50–1,000+ page books.config/klages_terminology.json) provisioned in GCP.services/neologism_detector.py,services/morphological_analyzer.py,services/philosophical_context_analyzer.py) and User Choice Manager (core/dynamic_choice_engine.py).Documents Included
spec/design.md: System design, sequence diagrams, GCS bucket folder structure, and component breakdown.spec/requirements.md: User Stories (US-01toUS-04), Functional Requirements (FR-01toFR-08) with formal Gherkin BDD scenarios, and Non-Functional Requirements.spec/tasks.md: Test-driven implementation plan with 4 execution tracks, explicit dependencies, parallelism highlights, and TDD/BDD acceptance criteria.docs/adr/0001-migrate-to-google-cloud-document-translation.md: Architecture Decision Record 0001.README.md: Preserved interactive Mermaid workflow diagram and links to new specifications.Greptile Summary
The PR establishes the specification suite and architecture decision for migrating full-book translation to Google Cloud Document Translation.
batchTranslateDocumentas the default book-scale pipeline.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Book upload] --> B[Neologism pre-scan] B --> C[Terminology review] C --> D[Composite glossary] D --> E[GCS staging] E --> F[Batch document translation] F --> G[LRO monitoring] G --> H[Translated PDF delivery]Reviews (3): Last reviewed commit: "fix(greploop): address Greptile review c..." | Re-trigger Greptile