Skip to content

Increase default NPS for the Sphere and the Sphere SDDR#514

Closed
mcampos16 wants to merge 41 commits intodevelopingfrom
increase_Sphere+SDDR_nps
Closed

Increase default NPS for the Sphere and the Sphere SDDR#514
mcampos16 wants to merge 41 commits intodevelopingfrom
increase_Sphere+SDDR_nps

Conversation

@mcampos16
Copy link
Copy Markdown
Contributor

This pull request applies an increase in the default NPS of the Sphere and the Sphere SDDR benchmarks from 1E8 to 1E9.
This change is applied to the run_cfg.yml file.

After the comparison between OpenMC (run with 1E8 particles) and MCNP (run with 1E9 particles) Sphere results, the benefit of applying this modification was highlighted. For example, for subcase Sphere_68164_Er-164:
image

Davide Laghi and others added 30 commits October 1, 2025 15:06
…esults-obtained-from-different-benchmark-versions-are-not-compared
…re-that-results-obtained-from-different-benchmark-versions-are-not-compared
@mcampos16 mcampos16 requested a review from dodu94 April 29, 2026 13:35
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • developing

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd1a0fea-a5ac-4896-942d-b2da3be88c13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch increase_Sphere+SDDR_nps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/jade/run/benchmark.py 79.41% 7 Missing ⚠️
src/jade/helper/aux_functions.py 86.66% 4 Missing ⚠️
src/jade/config/status.py 97.72% 1 Missing ⚠️
src/jade/post/plotter.py 92.30% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/jade/app/app.py 83.71% <100.00%> (+1.18%) ⬆️
src/jade/helper/errors.py 87.50% <100.00%> (+12.50%) ⬆️
src/jade/post/manipulate_tally.py 96.03% <100.00%> (ø)
src/jade/post/sim_output.py 93.56% <100.00%> (+0.13%) ⬆️
src/jade/config/status.py 96.47% <97.72%> (+0.32%) ⬆️
src/jade/post/plotter.py 94.10% <92.30%> (+0.26%) ⬆️
src/jade/helper/aux_functions.py 94.62% <86.66%> (+0.72%) ⬆️
src/jade/run/benchmark.py 86.34% <79.41%> (-0.66%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dodu94 dodu94 changed the base branch from pre_release_4_4 to developing April 29, 2026 15:00
@dodu94
Copy link
Copy Markdown
Member

dodu94 commented Apr 29, 2026

Hello @mcampos16 , I see that you did not create the branch from dev but from pre_release. I will close this PR, can I bother you opening another one?

@dodu94 dodu94 closed this Apr 29, 2026
@dodu94 dodu94 deleted the increase_Sphere+SDDR_nps branch April 29, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants