Repository navigation
Playlist bars follow the time signature - #403
Open
ItsAlphaNeon wants to merge 1 commit into
Open
ItsAlphaNeon wants to merge 1 commit into
ItsAlphaNeon wants to merge 1 commit into
Conversation
The playlist counted every bar as four quarter notes: Snap > Bar, the ruler's bar numbers, the bar lines and the Start marker's bar. The bar is now the project's (Project::bar_ticks), and a time-signature marker of the arrangement starts bars of its own length at its position (pl::Bars), as the channel rack and piano roll already follow the project's bar and a pattern's marker. Snap units count from the start of the bar they are in. The zoom stays counted in four quarter notes, so a tick's width does not change with the signature. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playlist counted every bar as four quarter notes (Snap > Bar, ruler numbers, bar lines, the Start marker's bar). It now uses the project's bar, and a time-signature marker in the arrangement starts bars of its own length from its position (the bar it lands in is cut short there).
playlist::Bars(floor, nearest, index, lines);snap_ticksandsnap_unitreplaceSnap::ticksin the playlist, with Bar = the project's bar. Units count from the start of the bar they are in (same result in 4/4).playlist_bar_w) stays the width of four quarter notes, so a tick's width and the saved view (event 242) don't change with the signature. The overview's extent counts the project's bars.Snap::ticksstill says 4 beats for Bar there).bars_follow_the_time_signature;cargo test -p os-app1145 passed (one ignored set unchanged).🤖 Generated with Claude Code