Repository navigation
Playlist Consolidate and Export all playlist tracks render hosted plugins - #401
Open
ItsAlphaNeon wants to merge 1 commit into
Open
ItsAlphaNeon wants to merge 1 commit into
ItsAlphaNeon wants to merge 1 commit into
Conversation
…gins Both rendered with a bare Engine::new on the UI thread: no hosted instruments and no hosted effects, so plugin channels and effect slots came out silent (and Consolidate then muted its source clips). They now run through the export path on the audio thread (App::start_export_of), one track at a time for the track export, so hosted plugins play as in File > Export. Files are 32-bit float WAV at the output device's rate; spans fix the lengths so track files line up. Consolidate still mutes its sources (the spec is silent; see REQUESTS 16). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tools rendered with a bare
Engine::newon the UI thread, with no hosted instruments or effects, so plugin channels and hosted effects came out silent. Consolidate then muted its source clips, which could leave silence.Now both run through the export path on the audio thread (
App::start_export_of); Export all playlist tracks renders one track after another. Files are 32-bit float WAV at the output device's rate, with a span so the track files line up.playlist_renders_play_hosted_plugins: a Lemon Trio channel is silent in a bare engine, audible in the track file and in the consolidated clip.cargo test -p os-app: 1144 passed, 0 failed, 64 ignored.🤖 Generated with Claude Code