Repository navigation
fix(watchlist): make Upcoming one grid, with the time windows as a filter - #83
Merged
Merged
Conversation
…lter Upcoming rendered a separate grid per time window, and both of its bugs came from that. A handful of pending titles spread across four windows became four rows holding one card each — with three fifths of every row empty. That is the ordinary case, not an edge case: three series in three windows is what a real list looks like. And the caption under each card overflowed its cell onto the next heading. The card fills its cell by design — `h-full` is what keeps a row of cards level — so a sibling placed after it inside the same grid item has nowhere to go. Measured at 23-39px of overlap, which is why titles and headings collided. The windows are a filter now: This week / This month / Later / No date, as chips beside the type control, with counts drawn from the same set the grid draws from so a chip reading "3" can never open onto an empty grid. An empty window is dropped, on the same reasoning as an empty status tab. The tab is always ordered soonest-first and gives up the sort dropdown to make room — it is the tab about *when*, the grouped view it replaces imposed that order too, and "Recently added" over a list of release dates answers nobody's question. With the grouping gone, Upcoming draws from the same grid as every other tab and the caption goes with it. Nothing is lost that the card does not already say: the poster badge carries how soon, the action slot carries the verb and the date, and the full weekday date was always in the detail sheet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80. Closes #82.
The two bugs, and why they were the same bug
Upcoming rendered a separate grid per time window. Everything in #80 follows from that.
"Almost one movie per row." Measured with three series spread across three windows: three sections, one card each, three fifths of every row empty. That is the ordinary shape of a real list, not an edge case.
Overlapping titles and posters. The caption under each card overflowed its grid cell onto the next section's heading — measured at 23–39px. Root cause:
MediaCard's<article>carriesh-full, which exists so a row of cards stays level. A grid item stretches, soh-fullresolves against a definite height and the card fills the cell exactly; the caption placed after it inside that same cell had nowhere to go. Every other tab is fine precisely because the card is the only child there.So the fix for #82 is the fix for #80: remove the grouping, and Upcoming draws from the same grid as the rest of the list — which is acceptance criterion #1 of #80, met literally rather than by imitation.
The windows as a filter
This week · This month · Later · No date, as chips beside the type control.All 3 / This week 1 / This month 1 / Later 1and the now-empty "No date" chip disappears — same reasoning as an empty status tab.The caption is gone with the grouping
Nothing is lost that the card does not already say: the poster badge carries how soon (
In 3 days), the action slot carries the verb and the date (Out Sep 11,Premieres Sep 15), a pending season shows asS4, and the full weekday date was always in the detail sheet.Verified
npm run check— 0 errors, 0 warnings;npm run lintcleanOne thing found along the way, not fixed here
playwright.config.tssetsreuseExistingServer: !process.env.CI. An unrelated Vite app was occupying port 5173 on this machine, so the whole suite silently ran against that app and reported 17/17 failures. It can equally hide a real failure behind someone else's server. Left alone here to keep this PR to the issues; recorded with evidence for #81.