Keep html-to-image at 1.11.11 - #129
Merged
Merged
Conversation
1.11.13 (#127) passed CI but its PNG export drops edge paths, the regression React Flow's guide warns about for later versions. Tell Dependabot to leave it alone.
|
Preview: https://b02c2cd6-terravisual.ilsproj.workers.dev Security headers were verified against this deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128.
Summary
Dependabot now ignores
html-to-imageversions above 1.11.11.Why
#127 (1.11.13) passed CI, but when I exported the starter diagram with it, the edge paths were missing: the to internet arrow kept its label and arrowhead, but the line was gone. React Flow's download-image guide pins 1.11.11 for this reason (#119). The E2E test checks the PNG file (signature, size), not what is drawn in it, so CI cannot catch the regression.
Security considerations
If a security fix ever lands above 1.11.11, this rule has to be revisited deliberately; Dependabot security alerts are not affected by
ignore.