Release 3.0.0 and publish on version tags - #7
Merged
Merged
Conversation
The 2.0.0 packages were already on the feed, so the #3 cleanup was never published: every push to main re-packed 2.0.0 and --skip-duplicate turned the 409 conflicts into a passing job. - Bump to 3.0.0; the #3 changes break the published 2.0.0 API. - Publish on vX.Y.Z tags and fail when the tag does not match the version in Directory.Build.props, which stays the single source of truth. - Drop --skip-duplicate so republishing an existing version fails loudly. - Skip symbol packages on push; GitHub Packages does not accept .snupkg. - Document the release steps in the README. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Why
The cleanup merged in #5 was never published. The release workflow re-packed the fixed version 2.0.0 on every push to
main, the feed returned409 Conflictfor all four packages, and--skip-duplicatelet the job pass anyway.Changes
src/Directory.Build.props. The Deep clean: dependency hygiene, PII leak, fail-fast config, remove reflection mapper #3 changes break the published 2.0.0 API.release.ymlnow runs onvX.Y.Ztags instead of every push tomain. It fails when the tag does not match the project version.--skip-duplicatewas removed, so republishing an existing version fails the job.--no-symbols, because GitHub Packages does not accept.snupkgfiles.After merge
Tag the merge commit with
v3.0.0and push the tag to publish.Validation
dotnet msbuild -getProperty:Versionreturns3.0.0locally, which matches the tag check.