Repository navigation
Never let root run a file the bot can write - #88
Merged
Merged
Conversation
The yt-dlp updater ran as root straight from the checkout, which the bot's unit could write. Install a root-owned copy in /usr/local/sbin, sandbox the updater, and narrow the bot's writable paths to its caches and cookies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
What changes
install-units.shinstallsupdate-ytdlp.shas a root-owned0755copy in/usr/local/sbin/loopify-ytdlp-update, and the updater unit runs that copy with the checkout as its argument. Root no longer executes anything the bot can write.PIP_NO_CACHE_DIR=1because pip's cache in the read-only home only produced a warning.ReadWritePathsgoes from the whole checkout to.cacheand the optionalcookies.txt, so a compromised bot cannot rewrite its own code.tests/test_service_sandbox.pykeep both properties.Verified on ilserver4
ashesofil, and the run printedyt-dlp already current (2026.08.19), exit 0.systemctl restart, issued from inside the same sandbox, restarts a unit (exit 0)..cacheand__pycache__in the checkout. Python skips the bytecode cache quietly when it cannot write it.