Skip to content

🞋 Round coordinates to ensure safe numbers#1

Merged
devarops merged 22 commits into
developfrom
hot_fix/safe_numbers
Oct 16, 2025
Merged

🞋 Round coordinates to ensure safe numbers#1
devarops merged 22 commits into
developfrom
hot_fix/safe_numbers

Conversation

@mvillasante

@mvillasante mvillasante commented Oct 10, 2025

Copy link
Copy Markdown
Member

Description

Relevant commits


Checklist for the author

  • Small: The pull request has fewer than 100 lines.
  • Passing: The CI pipeline is passing.
  • Comments: Did we replace unnecessary comments with clear variable names, well-named functions, and small cohesive blocks?
  • Complexity: Could the code be made simpler? Would another developer be able to easily understand and use this code when they come across it in the future? Is this code adding functionality that isn't presently needed?
  • Design: Is the code well-designed and appropriate for your system?
  • Documentation: Did the developer also update relevant documentation? Does the exposed functions have docstrigns?
  • CHANGELOG.md: Are the changes recorded in this file following this standard?
  • Versioning: Are version numbers updated according to semantic versioning guidelines (e.g., MAJOR.MINOR.PATCH)?
  • CITATION.cff: Is the citation files included and updated following the this standard?
  • Functionality: Does the code behave as the author likely intended? Is the way the code behaves good for its users?
  • Interface: Any interface changes are sensible and look good.
  • Naming: Did the developer choose clear names for variables, classes, methods, etc.?
  • Style: Does the code follow our style guides?
  • Tests: Does the code have correct and well-designed automated tests?
  • YAGNI: The developer is not implementing things they might need in the future but don’t know they need now.

@devarops devarops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Va muy bien, @mvillasante. Aquí están mis comentarios.

  • Add documentation to the function that are exported (#' @export)
  • Add the CITATION.md

@mvillasante mvillasante requested a review from devarops October 16, 2025 20:21
@devarops

devarops commented Oct 16, 2025

Copy link
Copy Markdown
Member

Checklist for the reviewer

  • Small: The pull request has fewer than 100 lines.
  • Passing: The CI pipeline is passing.
  • Comments: Did we replace unnecessary comments with clear variable names, well-named functions, and small cohesive blocks?
  • Complexity: Could the code be made simpler? Would another developer be able to easily understand and use this code when they come across it in the future? Is this code adding functionality that isn't presently needed?
  • Design: Is the code well-designed and appropriate for your system?
  • Documentation: Did the developer also update relevant documentation? Does the exposed functions have docstrigns?
  • CHANGELOG.md: Are the changes recorded in this file following this standard?
  • Versioning: Are version numbers updated according to semantic versioning guidelines (e.g., MAJOR.MINOR.PATCH)?
  • CITATION.cff: Is the citation files included and updated following the this standard?
  • Functionality: Does the code behave as the author likely intended? Is the way the code behaves good for its users?
  • Interface: Any interface changes are sensible and look good.
  • Naming: Did the developer choose clear names for variables, classes, methods, etc.?
  • Style: Does the code follow our style guides?
  • Tests: Does the code have correct and well-designed automated tests?
  • YAGNI: The developer is not implementing things they might need in the future but don’t know they need now.
  • Good Things: If you see something nice in the pull request, tell the developer, especially when they addressed one of your comments in a great way.

@devarops devarops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvillasante Muchas gracias for addressing all my comments. I liked that you included the ORCID to the authors and their GitHub usernames. Good work!

Image

@devarops devarops merged commit 92eed5b into develop Oct 16, 2025
1 check passed
@devarops devarops deleted the hot_fix/safe_numbers branch October 16, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants