Remove in-TUI terminal pane feature#700
Merged
Merged
Conversation
Deletes the terminal pane toggle (` / T), the internal/tui/terminal/ package, the view/terminal.go renderer, the :term/:t/:termdir commands, the ModeTerminal input-router state, and the terminal-specific mode badge / help entries. Replaces the terminalManager wrapper on Model with flat width/height fields plus a small mainAreaHeight() helper, since the only remaining consumers needed the pane-dimension math. Net: 30 files, -4539 / +113.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the in-TUI terminal pane that was toggled via
`/T/Ctrl+Shift+Tand focused via:t. Net -4539 / +113 across 30 files.What's gone:
internal/tui/terminal/package (manager + process + tests)internal/tui/view/terminal.gorenderer`/Tkey bindings,Ctrl+Shift+Tdir switch:term/:terminal/:t/:termdir *commandsinput.ModeTerminal,TransitionToTerminal,handleTerminalModeEnterTerminalMode/ToggleTerminal/TerminalDirModeresult fields,IsTerminalVisibledepModeBadgeTerminaland terminal-pane stylesTerminalFocused/TerminalVisible/TerminalDirModefields onHelpBarState,ModeIndicatorState,RenderContextrenderTerminalPaneand terminal lifecycle hooks inapp.Update()(cleanup, resize, output capture)What replaces it:
The
terminalManager *terminal.Managerfield onModelis replaced with two flatintfields (width,height) plus a smallmainAreaHeight(extraFooterLines int) inthelper that inlines the pane-dimension math the remaining callers need. Behavior is equivalent: sameHeaderFooterReservedconstant, same 10-line minimum clamp.Preserved (orthogonal to the pane):
tuimsg.BellMsg/RingBellstill forward tmux bells from instance sessionsCtrl+]still exits input modet/Tin filter mode still toggle the task categoryTest plan
go build ./...cleango vet ./...cleangofmt -l .cleango test -race ./...— all packages pass (one pre-existing failureTestGolangciLintComplianceininternal/is a Go 1.25/1.26 toolchain mismatch that also fails onmain)grepacross repo finds zero leftover references to removed symbols (terminalManager,ModeTerminal,IsTerminalVisible,TerminalFocused,ModeBadgeTerminal,renderTerminalPane, etc.)