Fix pipeline group navigation in ultraplan sidebar#699
Merged
Conversation
The pipeline/bridge execution path never updated session.CurrentGroup, leaving it at 0 permanently. This caused IsGroupCollapsed to return true for all groups except Group 1, hiding later groups from h/l navigation in the ultraplan sidebar. AssignTaskInstance now advances CurrentGroup forward (monotonic high-water-mark) when a task from a later execution group starts. This differs from the legacy path's sequential advancement via checkAndAdvanceGroup because the pipeline resolves dependencies at the task level, allowing tasks from multiple groups to run concurrently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.CurrentGroupwas never advanced in the pipeline/bridge execution path. The legacyExecutionOrchestrator.checkAndAdvanceGroup()updates it when groups complete, but the pipeline path bypasses this entirely — tasks flow through bridge → team → pipeline, never triggeringcheckAndAdvanceGroup. This leftCurrentGroupat0permanently, causingIsGroupCollapsed(groupIdx, 0)to returntruefor all groups except Group 1, hiding them from h/l sidebar navigation.AssignTaskInstancenow advancesCurrentGroupforward (monotonic high-water-mark) when a task from a later execution group starts. This correctly models the pipeline's concurrent execution where tasks from multiple groups can run simultaneously.CurrentGroupfield definitionTest plan
advances CurrentGroup when task belongs to later group— verifies forward advancement across 3 groupsdoes not regress CurrentGroup when earlier group task starts— verifies monotonic behaviorleaves CurrentGroup unchanged when task not in any group— verifies-1guardconcurrent calls advance CurrentGroup correctly under race— verifies correctness with 4 concurrent goroutines across 4 groupsTestCoordinator_AssignTaskInstancetests pass./internal/orchestrator/...test suite passes with-racegofmt,go vetclean