Reconcile pipeline task counts on team completion#696
Merged
Conversation
UpdateTeamCompleted overwrote TasksDone/TasksFailed with backend- authoritative values but left TasksTotal at the stale incremental count from bridge start events, causing "exec 3/2" when the backend reported more completed tasks than bridge had tracked starts. Now sets TasksTotal = tasksDone + tasksFailed and clears ActiveTasks on completion, matching the existing logic in the "team not yet tracked" branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec 3/2display bug where the task done count exceeded the total count in the pipeline status indicatorUpdateTeamCompletedoverwroteTasksDone/TasksFailedwith backend-authoritative values but leftTasksTotalat the stale incremental count from bridge start eventsTasksTotal = tasksDone + tasksFailedand clearsActiveTaskson team completion, matching the existing logic in the "team not yet tracked" branchTest plan
reconciles TasksTotal with backend counts— verifiesUpdateTeamCompletedsyncsTasksTotaland clearsActiveTaskswhen backend reports more tasks than bridge trackedexecution label after team completion reconciles counts— end-to-end test verifyingGetIndicatorshowsexec 3/3(notexec 3/2) after completion reconciliationgo build ./...,go vet ./...,gofmt -d .clean