Add StatusFinishing sidebar state for sentinel file detection#694
Merged
Conversation
Add a dedicated "finishing" status that activates between sentinel file detection and verification completion. This replaces the misleading "working" state during the VerifyWork phase. - Add StatusFinishing constant to InstanceStatus - Extend SessionRecorder interface with RecordSentinelDetected - Wire bridge to call RecordSentinelDetected before VerifyWork - Add teal color, bullseye icon, and FIN. abbreviation across all themes - Wire pipeline_wire callbacks via lock-safe SetInstanceStatus method - Include StatusFinishing in all session recovery methods
Iron-Ham
force-pushed
the
Iron-Ham/5ee736f8-we-should-have-a-state-in-the
branch
from
5cb2d79 to
2d96cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finishinginstance status that activates between sentinel file detection and verification completion, replacing the misleading "working" state during theVerifyWorkphaseSessionRecorderinterface withRecordSentinelDetected, called by the bridge monitor before verification runs◉), andFIN.abbreviation across all 14 theme palettesOrchestrator.SetInstanceStatus()(lock-safe) to prevent data racesStatusFinishingin all session recovery methods (NeedsRecovery,GetInterruptedInstances,MarkInstancesInterrupted,GetResumableInstances)Test plan
go build ./...passesgo vet ./...passesgo test -race ./internal/bridge/...— includesTestBridge_SentinelDetectedBeforeCompletionverifying orderinggo test -race ./internal/orchestrator/...— all orchestrator packages passgo test -race ./internal/tui/...— styles, view, and TUI tests passgo test -race ./internal/cmd/session/...passesgofmt -d .shows no formatting issues