Fix missing sentinel file in pipeline execution task prompts#691
Merged
Conversation
The bridge's BuildTaskPrompt relied solely on --append-system-prompt-file to inject the sentinel file instructions into task instances. If the system prompt injection failed silently, instances had no knowledge of the .claudio-task-complete.json convention and tasks would time out. Embed the completion protocol directly in the user prompt as the primary mechanism, with the system prompt injection as defense-in-depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claudio-task-complete.jsonsentinel files because the bridge'sBuildTaskPromptdid not include the completion protocol--append-system-prompt-file, which silently failed to reach instancesDetails
The old execution path (
phase/ExecutionOrchestrator) usedprompt.TaskBuilderwhich embedded the completion protocol directly in the user prompt. The 2.0 pipeline path (bridge+bridgewire) used a minimalBuildTaskPromptthat relied entirely on--append-system-prompt-fileto inject the protocol via the Claude Code CLI flag. If that flag didn't propagate (version mismatch, path issue, silently ignored), instances had no knowledge of sentinel files.The bridge package can't import
orchestrator/prompt(import cycle), socompletionFileNameis duplicated as a local constant with documentation pointing to the canonical source.Test plan
go test ./internal/bridge/... -racepassesgo test ./internal/orchestrator/bridgewire/... -racepassesgo test ./internal/orchestrator/prompt/... -racepassesgo vet ./...cleangofmt -d .clean