Graduate experimental features to default#689
Merged
Conversation
Ship intelligent naming, terminal support, inline multiplan, inline ultraplan, and grouped instance view as default features. Only subprocess mode remains experimental. Remove config struct fields, viper registrations, feature gates, disabled-state tests, and update all documentation. Also clean up stale triple_shot references from docs.
c652cb1 to
09fe54e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subprocess_moderemains experimentaltriple_shotreferences from documentationDetails
Config layer: Removed 5 fields from
ExperimentalConfig, keeping onlySubprocessMode. Updated defaults and viper registration.Gate removal: Removed
isTerminalEnabled(),terminalDisabledError, and all conditional checks in command handlers (cmdTerminal,cmdTerminalFocus,cmdTerminalDirWorktree,cmdTerminalDirProject,cmdMultiPlan,cmdUltraPlan), key handlers (handleToggleTerminal,handleSwitchTerminalDir), and orchestrator (initNamer).Intelligent naming:
IntelligentNamingEnabled()now always returnstrue. The namer still requiresANTHROPIC_API_KEY— the config gate was just an additional opt-in that's no longer needed.Tests: Removed
TestTerminalCommandsDisabled,TestTerminalKeybindingsDisabled,TestHandleNormalModeKeyTerminalDisabled, and "disabled by default" subtests from multiplan/ultraplan test suites. Removed allviper.Set("experimental.*")enablement calls from remaining tests.Net result: -468 lines, +32 lines. Removes
viperimports from 4 files.Test plan
go build ./...passesgo test -race ./...passes (only pre-existing golangci-lint toolchain mismatch)go vet ./...cleangofmt -d .cleanTestTUIConfigCoversAllConfigFieldsconfirms config struct/TUI editor synctriple_shotrefs) fixed