Dev networks - DO NOT MERGE#1688
Draft
jpraynaud wants to merge 3 commits into
Draft
Conversation
Test Results 5 files ± 0 206 suites ±0 56m 31s ⏱️ - 1h 55m 40s Results for commit 9164588. ± Comparison against base commit d1d2dae. This pull request removes 72 tests.♻️ This comment has been updated with latest results. |
jpraynaud
temporarily deployed
to
testing-sanchonet
May 16, 2024 16:38 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
May 17, 2024 11:28
2ed9469 to
0f5a44a
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 17, 2024 11:35 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
3 times, most recently
from
May 21, 2024 18:52
41ed35b to
e0f47e1
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 21, 2024 19:00 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
May 22, 2024 07:31
e0f47e1 to
1cd5b3a
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 22, 2024 07:38 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
4 times, most recently
from
May 23, 2024 08:12
a0e498c to
039003e
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 23, 2024 08:20 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
May 23, 2024 08:49
039003e to
fecabad
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 23, 2024 08:56 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
May 23, 2024 09:58
fecabad to
df9737a
Compare
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
May 24, 2024 14:54
26470f2 to
f45cd5a
Compare
jpraynaud
had a problem deploying
to
testing-preview
May 24, 2024 15:01 — with
GitHub Actions
Failure
jpraynaud
temporarily deployed
to
testing-sanchonet
May 24, 2024 15:01 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
May 24, 2024 15:20 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
2 times, most recently
from
May 30, 2024 14:22
c8df10f to
4066c06
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
May 30, 2024 14:31 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
June 5, 2024 16:46
4066c06 to
11e53c5
Compare
jpraynaud
temporarily deployed
to
testing-sanchonet
June 5, 2024 16:54 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/1687-optimize-cardano-tx-proof
branch
from
June 11, 2024 13:58
11e53c5 to
5bd3c65
Compare
jpraynaud
temporarily deployed
to
testing-preview
June 11, 2024 14:06 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
June 11, 2024 14:06 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR appears to be an experiment to improve/inspect GitHub Actions E2E log grouping and retry behavior for dev networks, by adjusting E2E logging, CI retry/matrix behavior, and adding timing diagnostics during chain import.
Changes:
- Re-enable GitHub Actions log grouping (
::group::/::endgroup::) in the E2E test lab utilities. - Enable the
allow_skip_signer_certificationfeature by default inmithril-common. - Add debug timing + counters around parsing/storing/rollback in the Cardano chain importer, and expand E2E CI attempts/logging.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| mithril-test-lab/mithril-end-to-end/src/utils/formatting.rs | Re-enabled GitHub Actions log grouping markers around E2E logs. |
| mithril-common/Cargo.toml | Changed default feature set to include allow_skip_signer_certification. |
| internal/cardano-node/mithril-cardano-node-chain/src/chain_importer/blocks_and_transactions_importer.rs | Added debug logs for parse/store/rollback elapsed time and counts. |
| .github/workflows/ci.yml | Increased E2E matrix repetitions and added retry step outputs / extra group logging. |
|
|
||
| [features] | ||
| default = ["num-integer-backend"] | ||
| default = ["num-integer-backend", "allow_skip_signer_certification"] |
Comment on lines
+454
to
+456
| echo "::group::Artificial group after e2e" | ||
| echo "This is a test" | ||
| echo "::endgroup::" |
|
|
||
| [features] | ||
| default = ["num-integer-backend"] | ||
| default = ["num-integer-backend", "allow_skip_signer_certification"] |
Re-activate as-is in order to see if there was some changes GH sides that solved the previous problem: logs of a retried run were lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is for tests only and must not be merged