feat: create workdir securely with 0o700 permissions - #147
Merged
Conversation
The workdir lives in the shared /var/tmp and was never explicitly created; filelock/create_delay_file would create it with default world-readable permissions. Add create_workdir() that makes it 0o700 and rejects a pre-existing symlink, non-directory or foreign-owned path to avoid hijacking. Call it before any lock/touch in cmd_create and delay_instance. Use pwd.getpwuid(os.geteuid()).pw_name instead of os.getlogin() for the workdir name (getlogin fails without a controlling terminal, e.g. detached/cron/container runs) and match the effective uid in the ownership check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workdir lives in the shared /var/tmp and was never explicitly created; filelock/create_delay_file would create it with default world-readable permissions. Add create_workdir() that makes it 0o700 and rejects a pre-existing symlink, non-directory or foreign-owned path to avoid hijacking. Call it before any lock/touch in cmd_create and delay_instance.
Use pwd.getpwuid(os.geteuid()).pw_name instead of os.getlogin() for the workdir name (getlogin fails without a controlling terminal, e.g. detached/cron/container runs) and match the effective uid in the ownership check.