chore(ci): drop verbose flag from the summary nix develop call - #169
Merged
Conversation
OlufemiAdeOlusile
force-pushed
the
chore/quiet-summary-nix-develop
branch
from
September 1, 2026 03:23
3fddea2 to
d823a5f
Compare
The pytest nix develop call already redirects into ci_step.log. It does not reach the console. The publish_result_summary.py call has no such redirect. Its -v flag prints every nixpkgs file Nix evaluates, straight to the visible job log. This adds hundreds of "evaluating file ..." lines after every run, with no debug value for a small Python script. Drop -v from this one call, in both workflows. The pytest build call keeps -v.
mkoura
force-pushed
the
chore/quiet-summary-nix-develop
branch
from
September 3, 2026 10:51
d823a5f to
895b6a8
Compare
mkoura
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #168.
Problem
Every run prints hundreds of lines like this, right after the tests
finish:
This has no debug value and makes the end of the job log hard to read.
Cause
Two workflows call
nix develop -vtwice per run. The first callbuilds and runs the pytest suite. Its output goes into
test_workdir/ci_step.log, not the console, so its verbosity doesnot show up in the visible job log.
The second call runs
publish_result_summary.py, a small scriptthat writes the job summary. It has no such redirect. Its
-vflagprints every nixpkgs file Nix evaluates, straight to the console.
Fix
Drop
-vfrom thepublish_result_summary.pycall, in bothnode_sync_test.yamlanddb_sync_full_sync.yaml. The pytest buildcall keeps
-v, since that output is still useful on a buildfailure and it is already contained in
ci_step.log.Testing
An independent review verified this directly, not just by reading
the diff: confirmed the removed
-vis the second occurrence inboth files (not the pytest build call), confirmed the rendered job
summary is byte-identical with and without
-von a real run ofthe devshell, and confirmed the script's own error path (a
corrupted results file) still surfaces its warning and traceback to
stderr without
-v. YAML syntax and indentation are unaffected.Correction to an earlier claim in this section: this change has
not been exercised by any dispatched CI run, and #168 does not
cover it either - both workflows here only trigger on
workflow_dispatch, and this commit is not on #168's branch, itsits on top of it. It merges verified by direct local testing of
the devshell, not by a live GitHub Actions run.