Skip to content

gRPC: update tests for latest v1beta UTXORPC - #6666

Draft
carbolymer wants to merge 2 commits into
masterfrom
mgalazyn/test/rpc-update-to-latest-v1beta-spec
Draft

gRPC: update tests for latest v1beta UTXORPC#6666
carbolymer wants to merge 2 commits into
masterfrom
mgalazyn/test/rpc-update-to-latest-v1beta-spec

Conversation

@carbolymer

Copy link
Copy Markdown
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

This reverts the temporary relaxation from 764a27f and extends the test.
cardano-rpc now resolves initial funds from the genesis sgExtraConfig, so the ReadGenesis response carries the wallets that create-testnet-data provisions.
The test now asserts the exact initialFunds map from the genesis file (extraConfig.initialFunds.data preferred, legacy top-level initialFunds as fallback), verifies the returned genesis hash equals the Blake2b-256 hash of the raw Shelley genesis file bytes, and covers the FAILED_PRECONDITION error for a genesis file that changed since the node started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant