Node SRE 11.1.1 updates - #6663
Merged
Merged
Conversation
`tryEval` caught too broadly, not only the intented `assert`. This turns an eval error into a red herring as its error message is replaced and stack trace discarded. There was no need for `tryEval` anyway as an `assert` already does what this code tried to implement.
dermetfan
force-pushed
the
jl/sre-11.1.1
branch
from
August 26, 2026 12:19
8419085 to
5b748b4
Compare
There was a problem hiding this comment.
Pull request overview
Updates Nix/NixOS configuration and mainnet topology inputs for Cardano node operations, aligning bootstrap peer changes and improving failure behavior when topology evaluation fails.
Changes:
- Update
iohk-nixinput revision inflake.lock. - Remove a mainnet bootstrap peer from
configuration/cardano/mainnet-topology.json. - Refactor the NixOS service topology assertion so topology evaluation errors propagate correctly (instead of being masked by the trustable-local-root check).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nix/nixos/cardano-node-service.nix | Refactors topology assertion logic for clearer/safer evaluation behavior. |
| flake.lock | Bumps the pinned iohk-nix dependency revision/hash. |
| configuration/cardano/mainnet-topology.json | Updates mainnet bootstrap peers list (removes one peer). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johnalotoski
marked this pull request as ready for review
August 26, 2026 20:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist