cardano-testnet: strengthen RPC ReadGenesis test coverage - #6657
Open
carbolymer wants to merge 1 commit into
Open
cardano-testnet: strengthen RPC ReadGenesis test coverage#6657carbolymer wants to merge 1 commit into
carbolymer wants to merge 1 commit into
Conversation
carbolymer
changed the base branch from
master
to
mgalazyn/test/rpc-readgenesis-followtip-fetchblock
August 20, 2026 14:21
carbolymer
marked this pull request as draft
August 20, 2026 14:22
carbolymer
force-pushed
the
mgalazyn/test/rpc-readgenesis-initialfunds
branch
from
August 20, 2026 14:25
9343bd0 to
521778a
Compare
Base automatically changed from
mgalazyn/test/rpc-readgenesis-followtip-fetchblock
to
master
August 20, 2026 15:11
carbolymer
force-pushed
the
mgalazyn/test/rpc-readgenesis-initialfunds
branch
from
August 26, 2026 14:54
521778a to
63d0675
Compare
carbolymer
marked this pull request as ready for review
August 26, 2026 14:58
carbolymer
force-pushed
the
mgalazyn/test/rpc-readgenesis-initialfunds
branch
from
August 26, 2026 15:04
63d0675 to
28a2d4d
Compare
This reverts the temporary relaxation from 764a27f and extends the test. cardano-rpc now resolves initial funds from the genesis sgExtraConfig, so the ReadGenesis response carries the wallets that create-testnet-data provisions. The test now asserts the exact initialFunds map from the genesis file (extraConfig.initialFunds.data preferred, legacy top-level initialFunds as fallback), verifies the returned genesis hash equals the Blake2b-256 hash of the raw Shelley genesis file bytes, and covers the FAILED_PRECONDITION error for a genesis file that changed since the node started.
carbolymer
force-pushed
the
mgalazyn/test/rpc-readgenesis-initialfunds
branch
from
August 27, 2026 14:16
28a2d4d to
a6566a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strengthens the UTxO RPC
ReadGenesisintegration test in cardano-testnet.initialFundsassertion (temporarily relaxed in 764a27f) and upgrades it to an exact comparison: the RPC response must match the funds embedded in the genesis file.The expectation prefers
extraConfig.initialFunds.data, wherecardano-cli create-testnet-dataembeds the funds, and falls back to the legacy top-levelinitialFunds, so the test keeps working when a future cardano-cli moves the funds back to the top level.ReadGenesisfails withFAILED_PRECONDITIONwhen the genesis file changed since the node started.This check runs before the first successful call, because the server caches the parsed genesis only on success.
The cardano-rpc fix this test depends on (IntersectMBO/cardano-api#1305, resolving initial funds from
sgExtraConfig) is already consumed from CHaP since the cardano-rpc 11.2 bump, so this PR is no longer stacked on anything and needs nosource-repository-packagestanza.Checklist
See Running tests for more details
CHANGELOG.mdfor affected packagecardano-node-chairman,cardano-submit-apiandcardano-testnetinstead need achangelog fragment in
<package>/.changes/, because theirCHANGELOG.mdis generatedfrom fragments at release time. Copy
_TEMPLATE.ymlfrom that directory, or runnix run github:input-output-hk/cardano-dev#herald -- new.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.