Support Dijkstra protocol-parameter updates - #1429
Merged
Merged
Conversation
palas
requested review from
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
August 27, 2026 13:32
palas
force-pushed
the
support-dijkstra-pparam-updates
branch
from
August 27, 2026 13:34
403754f to
67d8f14
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Dijkstra-era support to governance action protocol-parameter update construction by removing Dijkstra stubs, wiring the Dijkstra-era update type, and introducing parsers for the new Dijkstra protocol parameters (plus cost model attachment support).
Changes:
- Implement cost-model attachment for
DijkstraEraBasedProtocolParametersUpdate. - Add CLI parsers for Dijkstra-introduced protocol parameters (ref-script size limits and fee parameters) and construct
DijkstraEraBasedProtocolParametersUpdate. - Add a changelog fragment describing the Dijkstra protocol-parameter update support.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cardano-cli/src/Cardano/CLI/EraBased/Governance/Actions/Run.hs | Removes the Dijkstra stub by supporting cost-model attachment for Dijkstra-era PP updates. |
| cardano-cli/src/Cardano/CLI/EraBased/Governance/Actions/Option.hs | Adds parsers and wiring to build a Dijkstra-era protocol-parameter update value. |
| .changes/20260827_131104_cardano-cli_palas_dijkstra_pparam_updates.yml | Documents the change in the changelog (currently overstates CLI reachability). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
carbolymer
approved these changes
Aug 27, 2026
Creating a protocol-parameter update in the Dijkstra era hit an error stub; build DijkstraEraBasedProtocolParametersUpdate instead, with option parsers for the four parameters the era introduces (maximum reference-script size per block and per transaction, reference-script cost stride and multiplier), and extend cost-model attachment to the era. Co-Authored-By: Konstantinos Lambrou-Latreille <konstantinos.lambrou@iohk.io>
The reference-script cost multiplier reader rejected values with "expected a positive rational", which is misleading for positive values it also rejects: rationals whose numerator or denominator does not fit in 64 bits; state the representable range in the error.
palas
force-pushed
the
support-dijkstra-pparam-updates
branch
from
August 28, 2026 12:18
a9e5533 to
9f54f16
Compare
Jimbo4350
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Creating a protocol-parameter update proposal in the Dijkstra era hit two error stubs: building the update itself, and attaching cost models to it.
This PR fills both, the update is built as
DijkstraEraBasedProtocolParametersUpdate(from the released cardano-api), with option parsers for the four parameters the era introduces:And it also extends the cost-model attachment to the era.
Like the previous PR, these paths are not reachable from the command line yet: the Dijkstra
governancecommands arrive with the command-set PR later in this series, and these stubs must be gone before that lands.How to trust this PR
It is command line parsing and simple conversions. It is worth paying attention to both the conversions and the documentation (the help message descriptions, names, and meta-vars).
Checklist
.changes/