build(docker): skip FA2 when use cu13 #4356
Open
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker installation script to avoid FlashAttention 2 (FA2) installation failures on CUDA 13 by conditionally installing FA2 only for CUDA 12.x environments.
Changes:
- Add a CUDA-version guard around the FA2 wheel URL construction and
pip installstep so CUDA 13 images skip FA2 installation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
windreamer
force-pushed
the
fix_fa2_cu13
branch
from
fad3812 to
0a90802
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Flash Attention 2 does not provide pre-built wheels for CUDA 13.0. Installing FA2 on cu13 causes build failures, so we skip it for non-cu12 environments.
Modification
Conditionally install FA2 only when CUDA version matches cu12*, allowing cu13 to bypass the installation while preserving existing behavior for supported versions.