Fix Tensor Dimension Mismatch in Padding Operation for Batch Processing#254
Open
sugary199 wants to merge 2 commits intoInternLM:mainfrom
Open
Fix Tensor Dimension Mismatch in Padding Operation for Batch Processing#254sugary199 wants to merge 2 commits intoInternLM:mainfrom
sugary199 wants to merge 2 commits intoInternLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
pad_embedswas incorrectly constructed by repeating thepad_embedtensor along the wrong dimension, leading to a size mismatch when attempting to concatenate it withinputs['inputs_embeds'].The error message is as follows:
Modification: specifying the dimension as 1 when preparing pad_embeds.
This issue was not triggered by the official examples due to the difference in token counts across batches is 1 .Therefore I increase the difference in token numbers between the two examples