Fix stacked trees at zone boundaries#2778
Open
petchema wants to merge 1 commit intoInterkarma:masterfrom
Open
Conversation
TerrainSampler.HeightmapDimension returns a number of vertices, so (fence post problem) the height map dimension is heightmapScale.x * (HeightmapDimension - 1), not heightmapScale.x * HeightmapDimension. By using the latter, nature billboards are placed too far apart from one another, and the last billboard of a zone can land very close to the first billboard of the next zone. Say tDim = 128 and hDim = 129 (default values), scale = terrainData.heightmapScale.x * (float)hDim / (float)tDim = 6.4500003 largest x value is x = tDim - 1 = 127 x * scale = 819.14996 when zone is terrainData.heightmapScale.x * (float)(hDim - 1) = 819.2
Collaborator
Author
|
@KABoissonneault same bug exists in Location Loader |
Collaborator
|
Honestly not surprised to see off-by-ones in this code. Gonna have a look later, at least it's code I'm familiar with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerrainSampler.HeightmapDimension returns a number of vertices, so (fence post problem) the height map dimension is heightmapScale.x * (HeightmapDimension - 1), not heightmapScale.x * HeightmapDimension.
By using the latter, nature billboards are placed too far apart from one another, and the last billboard of a zone can land very close to the first billboard of the next zone.
Say tDim = 128 and hDim = 129 (default values),
scale = terrainData.heightmapScale.x * (float)hDim / (float)tDim = 6.4500003
largest x value is x = tDim - 1 = 127
x * scale = 819.14996
when zone is terrainData.heightmapScale.x * (float)(hDim - 1) = 819.2