Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes RPC client initialization reliability by adding configurable startup wait times and improving debug capabilities. The changes address endpoint discovery issues that could cause early RPC calls to fail by introducing an optional startup wait before the first RPC call.
Changes:
- Added
startup_waitparameter (default 3 seconds) to all RPC clients with support for customization viawith_startup_wait()constructors - Implemented RPC debug logging controlled by
BOOSTER_RPC_DEBUGenvironment variable with detailed request/response tracing - Changed QoS policy for RPC response topics from reliable to reliable+transient-local for better late-joiner support
- Reorganized Python package structure by removing centralized
types.pymodule in favor of per-client type exports - Added comprehensive docstrings to Python stub file (.pyi) for improved IDE support
- Version bump from 0.1.0-alpha.8 to 0.1.0-alpha.10
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pixi.toml | Version bump to 0.1.0-alpha.10 |
| booster_sdk_py/src/lib.rs | Added startup_wait validation helper and tracing initialization for Python bindings |
| booster_sdk_py/src/client/*.rs | Added startup_wait_sec parameter to all Python client constructors |
| booster_sdk_py/booster_sdk_bindings/booster_sdk_bindings.pyi | Added comprehensive docstrings for all classes and methods |
| booster_sdk_py/booster_sdk/types.py | Deleted centralized types module |
| booster_sdk_py/booster_sdk/client/*.py | Re-exported types from bindings with updated all lists |
| booster_sdk_py/booster_sdk/init.py | Removed types from package exports |
| booster_sdk_py/Cargo.toml | Added tracing-subscriber dependency |
| booster_sdk/src/dds/topics.rs | Changed RPC response topic QoS to reliable+transient-local |
| booster_sdk/src/dds/rpc.rs | Added startup_wait logic, debug logging, and configuration options |
| booster_sdk/src/dds/qos.rs | Added qos_reliable_transient_local_keep_last helper |
| booster_sdk/src/client/*.rs | Added with_startup_wait constructors to all RPC clients |
| README.md | Updated Python import example to use new module structure |
| Cargo.toml, Cargo.lock | Version bumps and dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.