feat(navigation): demonstrate nested tab navigators#1292
Open
hgray-instawork wants to merge 3 commits intomasterfrom
Open
feat(navigation): demonstrate nested tab navigators#1292hgray-instawork wants to merge 3 commits intomasterfrom
hgray-instawork wants to merge 3 commits intomasterfrom
Conversation
Collaborator
flochtililoch
left a comment
flochtililoch
left a comment
There was a problem hiding this comment.
Would it make sense to update the implementation of the demo app so it also implements this technique for its top tabs?
hgray-instawork
force-pushed
the
hardin/demo-nested-tabs
branch
from
1d916cd to
33a8930
Compare
| @@ -1,17 +1,13 @@ | |||
| {% macro tabbar_top(tabs) %} | |||
| <select-single id="tab-bar" name="tab-bar" style="tabbar-top-select"> | |||
| <view style="tabbar-top-container"> | |||
Collaborator
There was a problem hiding this comment.
Switching from select-single to view is the likely cause of the UI jankiness seen in your captured video when switching over to a tab that wasn't already loaded. Can the navigation actions be performed on the select behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a demo in the navigation section of the demo app to illustrate how navigators can be nested to provide a bottom tab/top tab UI. The nested navigator exists in a separate file to show have the navigation hierarchy can be dynamically expanded.
Added an example in Advanced/Case Studies for a top nav bar.
Updated the demo to use nested navigation for top tabs.
Asana