Skip to content

fix: draw the login page's wave whole in the dark themes - #307

Merged
InstaZDLL merged 1 commit into
mainfrom
fix/login-signal
Oct 23, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
fix/login-signal

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

The wave under the login page's headline looked cut off in the dark themes (reported from the dev server).

Why: the dark themes draw .signal as the Fluid Editorial wave, through a CSS mask in fluid.css. The light theme's rule in styles.css also gives .signal a clip-path polygon, which cuts its bars into a jagged line. Nothing in the dark rule cleared it, so the polygon cut the wave itself.

Fix: clip-path: none in :where(:root.dark) .signal. The light themes keep their look.

Checked:

  • a dark-theme screenshot of /login shows the wave whole;
  • lint passes with the same 7 warnings, all in refresh.css.

There is no automated test: a screenshot comparison is not part of this suite.

Summary by CodeRabbit

  • Corrections
    • En mode sombre, l’onde du signal n’est plus tronquée.

The dark themes draw .signal as the Fluid Editorial wave through a mask, but the light theme's clip-path, which cuts its bars into a jagged line, still applied and cut the wave too: the motif under the login headline looked broken. The dark rule now clears the clip-path.

Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@github-actions github-actions Bot added scope: web Embedded web player (React) type: fix Bug fix size: xs < 10 lines labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 8da2825 and d2ac56d.

📒 Files selected for processing: 1
  • webapp/src/styles/fluid.css

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

📝 Walkthrough

La règle sombre .signal définit clip-path: none pour empêcher le découpage du motif d’onde.

Changes: Rendu de l’onde

Layer / File(s) Summary
Désactivation du découpage
webapp/src/styles/fluid.css
La règle .signal ajoute clip-path: none.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to d2ac5

No actionable merge-blocking risk is established for this scoped visual change.

Architecture risk: 🔵 Low · up to d2ac5

The change affects 1 system.

Changed systems: webapp

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — webapp (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in webapp/src/styles/fluid.css: La règle .signal ajoute une déclaration qui désactive le clip-path et empêche le découpage du motif d’onde.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed Le titre décrit précisément la correction principale : l’affichage complet de l’onde de la page de connexion dans les thèmes sombres.
Description check Passed La description explique le problème, sa cause, la correction et la validation effectuée. Elle ne reprend pas les sections exactes du modèle ni les cases du plan de test, mais elle reste suffisamment c…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

La description explique le problème, sa cause, la correction et la validation effectuée. Elle ne reprend pas les sections exactes du modèle ni les cases du plan de test, mais elle reste suffisamment complète et pertinente.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.15)
webapp/src/styles/fluid.css

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added type: fix Bug fix and removed type: fix Bug fix labels Oct 23, 2026
@InstaZDLL InstaZDLL self-assigned this Oct 23, 2026
@InstaZDLL
InstaZDLL merged commit 89ccc23 into main Oct 23, 2026
15 of 16 checks passed
@InstaZDLL
InstaZDLL deleted the fix/login-signal branch October 23, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: web Embedded web player (React) size: xs < 10 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant