Repository navigation
fix: draw the login page's wave whole in the dark themes - #307
Conversation
The dark themes draw .signal as the Fluid Editorial wave through a mask, but the light theme's clip-path, which cuts its bars into a jagged line, still applied and cut the wave too: the motif under the login headline looked broken. The dark rule now clears the clip-path. Signed-off-by: InstaZDLL <github.105mh@8shield.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
The wave under the login page's headline looked cut off in the dark themes (reported from the dev server).
Why: the dark themes draw
.signalas the Fluid Editorial wave, through a CSS mask influid.css. The light theme's rule instyles.cssalso gives.signalaclip-pathpolygon, which cuts its bars into a jagged line. Nothing in the dark rule cleared it, so the polygon cut the wave itself.Fix:
clip-path: nonein:where(:root.dark) .signal. The light themes keep their look.Checked:
/loginshows the wave whole;refresh.css.There is no automated test: a screenshot comparison is not part of this suite.
Summary by CodeRabbit