Skip to content

feat: call the unfiled tracks To sort, and say WaveFlow keeps the list - #306

Merged
InstaZDLL merged 1 commit into
mainfrom
feat/to-sort
Oct 23, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
feat/to-sort

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

On the dev server, the owner found Unfiled unclear. It read as a folder like the others, one that could be renamed, or as the place uploads land. It is neither: it is the list of every track in no folder, and WaveFlow keeps it itself. It is renamed To sort (French: À ranger), the owner's choice.

What changes (web client only)

  • Name: filed.unfiled reads "To sort" / "À ranger" everywhere it shows: its card, its view's title, the trail, the folder picker's first entry when filing a track, and the "filed in" notice.
  • It says it is WaveFlow's:
    • its card shows a tray icon (new inbox icon) instead of a folder;
    • an Automatic badge (.folder-badge) sits next to its name;
    • its view explains that WaveFlow keeps the list, that a track leaves it as soon as it is filed, and that it cannot be renamed or deleted. Owners and managers are also told how to file a track from its menu.
  • Where tracks go back: the delete confirmation, the delete notice and the two upload lines now say "back in To sort" or "go to To sort" instead of "unfiled".

The API keeps unfiled (unfiled_track_count, …/folders/unfiled/tracks): this is a label change, not a contract change.

Checked in a dark-theme screenshot of the root on desktop and mobile.

Tests

Playwright strings follow the new labels. The filing test also checks the Automatic badge on the To sort card, and fails when the badge is emptied (checked on a build that compiles).

Validation

  • webapp: lint (the same 7 warnings in refresh.css), tsc, 190 unit tests, build
  • Playwright: 188 passed, 12 skipped

Summary by CodeRabbit

  • Interface
    • La liste « À ranger » est désormais identifiée par une icône de boîte de réception et un badge « Automatique ».
    • Les libellés précisent que cette liste est gérée par WaveFlow et ne peut être ni renommée ni supprimée.
  • Classement des pistes
    • Les pistes importées sans destination valide, ou dont le classement échoue, apparaissent dans « À ranger ».
    • Supprimer un dossier renvoie ses pistes dans cette liste.
    • Les messages d’import et de suppression indiquent où retrouver les pistes.

Unfiled read as a folder that could be renamed, or as one holding uploads. It is the list of every track in no folder, kept by WaveFlow: it is now named To sort (À ranger), drawn with a tray rather than a folder and an Automatic badge, and its view says a track leaves it once filed and that it cannot be renamed or deleted. The delete confirmation, the delete notice and the upload lines say where tracks go back to.

Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@github-actions github-actions Bot added scope: web Embedded web player (React) scope: components Web UI components type: feat New feature labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 515201b and afa6974.

📒 Files selected for processing: 5
  • webapp/e2e/studio-nocturne.spec.ts
  • webapp/src/components/icons.tsx
  • webapp/src/pages/folders-page.tsx
  • webapp/src/state/i18n.tsx
  • webapp/src/styles/styles.css

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

📝 Walkthrough

La liste sans dossier est renommée « À ranger » en français et « To sort » en anglais. Sa carte reçoit une icône inbox et un badge « Automatique ». Les traductions et les tests E2E décrivent aussi sa gestion par WaveFlow et le retour des pistes dans cette liste.

Changes: Liste « À ranger »

Layer / File(s) Summary
Libellés et messages
webapp/src/state/i18n.tsx
Les traductions remplacent « Unfiled » et « Non classés » par « To sort » et « À ranger ». Elles décrivent la gestion de la liste par WaveFlow et précisent où vont les pistes après certaines opérations.
Présentation de la carte
webapp/src/components/icons.tsx, webapp/src/pages/folders-page.tsx, webapp/src/styles/styles.css
La carte sans dossier utilise une nouvelle icône inbox et affiche un badge automatique. Les cartes de dossiers conservent leur icône et n’affichent pas ce badge.
Assertions des tests E2E
webapp/e2e/studio-nocturne.spec.ts
Les assertions utilisent le nouveau nom de liste et vérifient le badge, le retour des pistes après suppression et les messages liés à l’envoi ou au classement.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to afa69

The change is limited to the To sort presentation, translations, and related test expectations; the underlying filing behavior remains unchanged.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed Le titre décrit clairement le changement principal : remplacer « Unfiled » par « To sort » et indiquer que WaveFlow gère cette liste.
Description check Passed La description couvre le résumé, les changements, les tests, la validation, le maintien du contrat API et la vérification visuelle. Elle n’utilise pas exactement les sections du modèle et ne reprend p…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

La description couvre le résumé, les changements, les tests, la validation, le maintien du contrat API et la vérification visuelle. Elle n’utilise pas exactement les sections du modèle et ne reprend pas la confirmation explicite AGPL/DCO, mais le contenu requis est majoritairement présent.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.15)
webapp/e2e/studio-nocturne.spec.ts

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

webapp/src/components/icons.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

webapp/src/pages/folders-page.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

  • 2 others

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size: s 10-50 lines type: feat New feature and removed type: feat New feature labels Oct 23, 2026
@InstaZDLL
InstaZDLL merged commit 8da2825 into main Oct 23, 2026
16 checks passed
@InstaZDLL
InstaZDLL deleted the feat/to-sort branch October 23, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: components Web UI components scope: web Embedded web player (React) size: s 10-50 lines type: feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant