Skip to content

fix(webapp): let the player's cover take its clicks, and give the bar room #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InstaZDLL merged 1 commit into from
Oct 21, 2026
Merged

fix(webapp): let the player's cover take its clicks, and give the bar room #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions webapp/src/styles/fluid.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@
/* The player bar runs under the rail's foot now, so the rail ends above it. */
@media (width > 820px) {
:where(:root.dark) .sidebar {
padding-bottom: calc(4.75rem + var(--space-4));
padding-bottom: calc(5.75rem + var(--space-4));
}
}

Expand Down Expand Up @@ -731,6 +731,12 @@
border-bottom-color: rgb(255 255 255 / 5%);
}

/* Rows with room inside them: the open one is a tone with the accent's edge,
and a cover pressed against that edge read as cut off. */
:where(:root.dark) :is(.queue-list li, .bookmark-list li) {
padding-inline: var(--space-3);
}

:where(:root.dark) .queue-list li.active {
background: var(--fe-tone-2);
box-shadow: inset 2px 0 0 var(--accent);
Expand All @@ -740,6 +746,14 @@
border-radius: var(--fe-radius-tile);
}

/* The row's own button is the row, not a ghost pill inside it: hovered, it
took the pill's tone and full radius and drew a second card in the first. */
:where(:root.dark) :is(.queue-track, .bookmark-track),
:where(:root.dark) :is(.queue-track, .bookmark-track):hover {
border-radius: 0;
background: transparent;
}

:where(:root.dark) .view-switcher {
border: 0;
border-radius: 999px;
Expand Down Expand Up @@ -954,9 +968,9 @@
grid-template-columns: minmax(0, 1fr) minmax(18rem, 38rem) minmax(0, 1fr);
grid-template-rows: auto auto;
column-gap: var(--space-6);
row-gap: 0;
min-height: 4.25rem;
padding: var(--space-2) var(--space-6);
row-gap: var(--space-1);
min-height: 5.25rem;
padding: var(--space-3) var(--space-6);
border-radius: 0;
box-shadow: inset 0 1px 0 var(--fe-hairline);
}
Expand All @@ -967,26 +981,33 @@
grid-area: 1 / 1 / 3 / 2;
align-self: center;
justify-self: start;
width: 3.25rem;
width: 3.75rem;
}

:where(:root.dark) .player-cover {
width: 3.25rem;
width: 3.75rem;
}

/* Set beside the cover by a margin, not a padding: a padded box still
covers the cover it sits over, and took every click aimed at the middle
of it — only the strip above the names reached the album link. */
:where(:root.dark) .player-track {
grid-area: 1 / 1 / 3 / 2;
align-self: center;
padding-left: calc(3.25rem + var(--space-3));
margin-left: calc(3.75rem + var(--space-3));
}

:where(:root.dark) .player-track strong {
font-size: var(--fe-body);
}

:where(:root.dark) .player-controls {
grid-area: 1 / 2;
}

:where(:root.dark) .player-controls button.primary {
width: 2.5rem;
min-height: 2.5rem;
width: 2.75rem;
min-height: 2.75rem;
}

:where(:root.dark) .player-controls button.primary:hover {
Expand Down
Loading