Skip to content

chore(release): backport the 1.9.6 fixes - #934

Merged
InstaZDLL merged 2 commits into
release/1.9.xfrom
backport/1.9.6
Oct 22, 2026
Merged

InstaZDLL merged 2 commits into
release/1.9.xfrom
backport/1.9.6

Conversation

@InstaZDLL

Copy link
Copy Markdown
Owner

Backport of the 1.9.6 fix to release/1.9.x. It is a patch release for #932: on 1.9.x, every track that is followed by another loses its last second. Merge #933 into main first, so the fix lands there before it ships here.

  • fix(player): play the end of a track out of the ring before the next one starts #933: play the end of a track out of the ring before the next one starts.
    • The gapless and crossfade triggers read the decoder's position instead of the heard one. The gapless swap, which keeps the tail, now actually runs.
    • At a natural end, both play loops wait until the output has played the ring out before declaring the track over.
    • That wait survives a pause and an A-B jump, and gives up on a stalled output.
    • Measured on a 139.2 s FLAC, seeking 4 s before its end: main heard 3.82 s, the fix hears 4.09 s.

Both commits cherry-picked without conflict. The 1.9.x tree already has the same position clock (clock_lead_in, three-argument restart_clock), so no adaptation was needed.

Checks on this branch

  • cargo fmt --check passes.
  • cargo clippy --locked --workspace --all-targets passes on Windows. The lockfile is unchanged.
  • On macOS, cargo clippy -D warnings passes and the audio module's tests pass: 200 on the first commit, before the follow-up was cherry-picked.
  • The local CodeRabbit review's findings on this diff were fixed in fix(player): play the end of a track out of the ring before the next one starts #933 (the pause gap, the A-B jump) and cherry-picked here.

@InstaZDLL InstaZDLL added scope: backend Rust/Tauri backend (src-tauri/) scope: docs Docs, README, assets type: chore Maintenance / tooling size: l 200-500 lines labels Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: InstaZDLL/WaveFlow/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: abde2b38-dcd3-4540-badd-76c972d2d60d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Oct 21, 2026
@InstaZDLL
InstaZDLL merged commit 1028cc9 into release/1.9.x Oct 22, 2026
11 checks passed
@InstaZDLL
InstaZDLL deleted the backport/1.9.6 branch October 22, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: backend Rust/Tauri backend (src-tauri/) scope: docs Docs, README, assets size: l 200-500 lines type: chore Maintenance / tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant