Repository navigation
chore(release): backport the 1.9.6 fixes - #934
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the 1.9.6 fix to
release/1.9.x. It is a patch release for #932: on 1.9.x, every track that is followed by another loses its last second. Merge #933 intomainfirst, so the fix lands there before it ships here.mainheard 3.82 s, the fix hears 4.09 s.Both commits cherry-picked without conflict. The 1.9.x tree already has the same position clock (
clock_lead_in, three-argumentrestart_clock), so no adaptation was needed.Checks on this branch
cargo fmt --checkpasses.cargo clippy --locked --workspace --all-targetspasses on Windows. The lockfile is unchanged.cargo clippy -D warningspasses and the audio module's tests pass: 200 on the first commit, before the follow-up was cherry-picked.