Repository navigation
chore(release): backport the 1.9.2 fixes - #870
Merged
Merged
Conversation
…rst (#869) * ci(release): cut patch releases from maintenance branches, and tag first release-please also runs on release/** branches, targeting the pushed branch, so a fix for a shipped line can be released without the features already on main; the Cargo.lock build accepts release PRs into those branches. The GitHub release step now runs before the release PR update: in the other order the update walked 1,500 commits looking for a release not yet created, and the timeout cut the job before the tag. RELEASING.md documents the maintenance branch, and that release.yml must be started by hand for a tag the workflow made. * ci(release): pin release-please, and say how release branches are protected npx release-please@17 resolved to whatever 17.x was current at each run, with the write token; it is pinned to 17.11.2. RELEASING.md now says the workflow runs on maintenance branches and tags the branch it targets, that release.yml is started by hand for that tag, and that a Maintenance branches ruleset protects release/** like main, without the CodeQL gate. * ci(release): bind the lockfile artifact to the run that built it The privileged push checked the PR the artifact names, not that the artifact was built for it: the PR must now be one GitHub attached to the triggering run, at the same branch and head SHA, or the push fails before any write. RELEASING.md gives the release PR title on a maintenance branch. (cherry picked from commit 18d12e2)
…hover (#868) A clicked row took a focus ring as soon as any key was pressed, a desktop shortcut such as Super+Q under Hyprland included, and kept it until the next click. Focus is now marked when it arrives from a pointer, and a marked element stays ringless; keyboard focus keeps its ring. The Escape-only workaround goes. The row checkbox no longer shows on hover in either click mode: a selection starts with Ctrl or Shift + click, or Ctrl+A. Fixes #866 Fixes #867 (cherry picked from commit 5cdbcf1)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
InstaZDLL
added
scope: frontend
… the window Minimising or leaving the window took focus from the clicked row, which dropped its pointer-focus mark; on return it took focus again, and with a key as the last input it came back unmarked and ringed. The mark is now dropped only once focus has moved elsewhere in the page, and focus that returns from outside the page keeps the mark it had. Refs #866 (cherry picked from commit c148dcc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to
release/1.9.xfor 1.9.2.mainalready carries 2.0 work (#864, #855), so the patch is cut from the maintenance branch (seedocs/RELEASING.md, "Patch releases from a maintenance branch").Cherry-picked, signed, with
-x:ci(release). It brings the maintenance-branch support to this branch, because a push torelease/1.9.xruns this branch's copy ofrelease-please.yml. It also brings the tag-first order and the pinned release-please.fix(ui). No focus ring on what the mouse focused (bug: 键盘win键会误触 #866), and no row checkbox on hover (feat: 双击播放模式下可以改成和单机播放模式一样默认隐藏复选框么？ #867).Both apply cleanly on
v1.9.1.bun run typecheckandeslintare clean on this branch.Once merged, release-please opens
chore(release/1.9.x): release 1.9.2against this branch.