Skip to content

fix(editor): mount the new-company human check on the editor route - #371

Merged
important-new merged 1 commit into
InspectorHub:mainfrom
important-new:fix/editor-human-check
Oct 12, 2026
Merged

important-new merged 1 commit into
InspectorHub:mainfrom
important-new:fix/editor-human-check

Conversation

@important-new

Copy link
Copy Markdown
Contributor

Summary

The full-screen editor route is declared outside the workspace layout, so the provider that raises the new-company human check was never mounted there. Publishing from the editor in a company's first 24 hours therefore showed no check, and the report mail it queued was never vouched for, so the delivery pass held it until the window ends. (Found while testing the check on a live deployment.)

  • The editor's loader already fetches the session context; it now also returns the open cooling window and Turnstile site key.
  • A small EditorHumanCheck component mounts the provider above the page; the route only gains a thin default-export wrapper.
  • The publish dialog takes the unlock time from a prop, because it read it from a session context the editor does not have, so its new-company notice never showed there.

Test plan

  • Loader: passes the open window through; null when closed, absent, or the session context can't be read.
  • EditorHumanCheck: a publish inside a window asks for the check; with no window it resolves at once.
  • Publish dialog: shows the notice from its prop.
  • Verified against the live deployment after merge.

🤖 Generated with Claude Code

https://claude.ai/code/session_01C8qkG1Y2agL9r9s3CXziwF

…reen editor

The editor route is declared outside the workspace layout, so the provider that
raises the human check was never mounted there: publishing from the editor in a
new company's first 24 hours showed no check, and the report mail it queued was
never vouched for, so the delivery pass held it until the window ends. The editor
already fetches the session context for its preview link, so its loader now also
returns the open cooling window and site key, the page mounts the provider, and
the publish dialog takes the unlock time from a prop (it read it from a session
context the editor does not have, so its new-company notice never showed there).
Tests cover the loader, the dialog prop and the EditorHumanCheck component; that the
route uses it is checked on the live deployment rather than by a unit test.

The provider mount lives in a small EditorHumanCheck component (with its own test), so the route only gains a thin default-export wrapper, the import and one prop. File-size baseline for the editor route raised by 12 lines for exactly that wiring.

chrome-allow: the check and the notice only appear for a SaaS company inside its first 24 hours, which a standalone dev server cannot produce; the fix is verified against the live SaaS after deploy

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C8qkG1Y2agL9r9s3CXziwF
@important-new
important-new merged commit e503fd6 into InspectorHub:main Oct 12, 2026
20 checks passed
@important-new important-new changed the title Editor: mount the new-company human check on the full-screen editor route fix(editor): mount the new-company human check on the editor route Oct 12, 2026
@important-new
important-new deleted the fix/editor-human-check branch October 13, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant