feat: add custom OAuth provider support#14
Merged
Conversation
- Changed not() signature from value: Any to value: Any? - null maps to 'null' string for PostgREST (e.g. not.is.null) - Applied to TableQuery, UpdateQuery, and DeleteQuery - Added test for not(col, 'is', null)
Contributor
Author
|
Hey @jwfing —> this PR adds custom OAuth provider support to the Kotlin SDK, completing the rollout across all three SDKs (JS, Swift, Kotlin). Same non-breaking approach as the Swift PR: OAuthProvider enum is untouched, and two new overloads (getOAuthUrl and signInWithOAuthPage) accept a providerKey: String that routes to /oauth/custom/{key}. URL encoding is handled via Ktor's appendPathSegments — single encoding, no double-encoding issues. Ready for review whenever you get a chance! |
jwfing
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds non-breaking support for custom OAuth providers configured in the InsForge dashboard, mirroring the approach already implemented in the JS SDK and Swift SDK.
This work stems from InsForge/InsForge#859 which added backend support for custom OAuth providers with configurable credentials and OIDC discovery endpoints.
Changes
getOAuthUrl(providerKey: String, redirectUri, codeChallenge)— new overload that routes to/oauth/custom/{key}for dashboard-configured custom providerssignInWithOAuthPage(providerKey: String, redirectUri)— new overload with full PKCE flow, generates code verifier/challenge and launches browserOAuthProviderenum is completely untouched — no source-breaking changes, existing consumers are unaffectedappendPathSegments("oauth", "custom", providerKey)for URL construction — provider key is encoded exactly once as a single path segment (avoids double-encoding and slash pass-through issues)Usage