Skip to content

fix(link): note that browser sign-in may happen at provisioning time#124

Merged
CarmenDou merged 1 commit into
mainfrom
fix/link-skills-login-hint
May 12, 2026
Merged

fix(link): note that browser sign-in may happen at provisioning time#124
CarmenDou merged 1 commit into
mainfrom
fix/link-skills-login-hint

Conversation

@CarmenDou
Copy link
Copy Markdown
Contributor

@CarmenDou CarmenDou commented May 12, 2026

Summary by cubic

Updated the “What’s next” note in the projects link flow to explain that if you’re not signed in, your browser will open for sign-in during provisioning triggered by your coding agent. This prevents confusion for skills-only users who didn’t authenticate during linking.

Written for commit fb0e631. Summary will update on new commits.

Summary by CodeRabbit

  • Documentation
    • Updated guidance messages to clarify that the coding agent will guide provisioning when needed and that users will be prompted to sign in via browser if not already authenticated.

Review Change Stack

The skills-only path doesn't require auth, so users walk away assuming
no further login. Add a heads-up to the "What's next" note that if
they're not signed in yet, the browser will open when the agent
triggers provisioning.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0dcc77b-083e-43c2-b62f-4230b504cf91

📥 Commits

Reviewing files that changed from the base of the PR and between 2c2beec and fb0e631.

📒 Files selected for processing (1)
  • src/commands/projects/link.ts

Walkthrough

The PR updates a single user-facing message in the insforge/cli link command's skills-only fast path (no arguments). The "What's next" note displayed in non-JSON mode now includes guidance that the coding agent will handle provisioning when needed and that the browser will open for sign-in if the user is not authenticated.

Changes

Link Command Guidance Update

Layer / File(s) Summary
Skills-only link What's next guidance
src/commands/projects/link.ts
Non-JSON "What's next" message updated to include guidance about provisioning via the coding agent and browser sign-in behavior for unauthenticated users.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • InsForge/CLI#120: Updates the same insforge/cli link skills-only fast path and early behavior, including related sign-in and provisioning messaging changes.

Suggested reviewers

  • jwfing

Poem

A message refined with care so fine,
The agent and sign-in align,
When skills alone will do the trick,
The path grows clear, the way less thick. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a note about browser sign-in possibly occurring during provisioning in the link command's output.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/link-skills-login-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Copy link
Copy Markdown
Member

@jwfing jwfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved.

@CarmenDou CarmenDou merged commit 1924f64 into main May 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants