fix(cli): surface container port in compute deploy/update output#116
fix(cli): surface container port in compute deploy/update output#116tonychang04 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe compute service CLI now prints the configured container port in deploy (image and source modes) non-JSON output, and the update command additionally prints the endpoint URL and port in non-JSON success output. ChangesCompute Service Output Enhancement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Print "Port: <n>" alongside the endpoint on success so users can spot image-vs-port mismatches (e.g. nginx:alpine listening on 80 deployed with the default --port 8080) without having to inspect the service. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4cdd892 to
299e2b6
Compare
|
Consolidated into #109 (the compute port output fix is now part of the unified PR for combined review/merge). |
Summary
Port: <n>alongsideEndpoint:oncompute deployandcompute updatesuccess output (both image mode and source mode)nginx:alpine(listens on 80) deployed with the default--port 8080results in an unreachable endpoint with no signal in the CLI outputBefore
After
Test plan
npx @insforge/cli compute deploy --name test --image nginx:alpineshowsPort: 8080(and endpoint is unreachable — confirms the line surfaces the misconfiguration)npx @insforge/cli compute deploy --name test --image nginx:alpine --port 80showsPort: 80(and endpoint serves the nginx welcome page)npx @insforge/cli compute update <id> --port 80shows the updated port🤖 Generated with Claude Code
Summary by cubic
Show the container port alongside the endpoint in
@insforge/clicompute deploy and update success output. This helps catch image-vs-port mismatches (e.g., nginx on 80 vs--port 8080).Written for commit 299e2b6. Summary will update on new commits.
Summary by CodeRabbit
compute deploynow shows the configured container port in text output for both image and source deployments.compute updatenow shows the service endpoint URL and the configured container port in text output after successful updates.