Swapped Newtonsoft.Json for System.Text.Json#20
Open
jamesburton wants to merge 2 commits into
Open
Conversation
jukkahyv
reviewed
Feb 9, 2025
|
|
||
| private static string Json(T instance) { | ||
| return JsonConvert.SerializeObject(instance); | ||
| return JsonSerializer.Serialize(instance, EfCoreJsonValueConverterConfiguration.DefaultJsonSerializerOptions); |
Contributor
There was a problem hiding this comment.
I guess this could make use of JsonHelper.
jukkahyv
reviewed
Feb 9, 2025
| namespace Innofactor.EfCoreJsonValueConverter; | ||
|
|
||
| /// <summary>A static configuration class to expose the serializer settings used for the JSON value converter.</summary> | ||
| public static class EfCoreJsonValueConverterConfiguration |
jukkahyv
reviewed
Feb 9, 2025
| var serialized = (string)converter.ConvertToProvider(customer); | ||
| Assert.IsFalse(serialized.Contains("Privet"), "Serialization applied custom converter"); | ||
| var serialized = (string)converter.ConvertToProvider(customer); | ||
| //Assert.IsTrue(serialized.Contains("Privet"), "Serialization applied custom converter"); |
Contributor
There was a problem hiding this comment.
Better remove this commented out code
jukkahyv
approved these changes
Feb 9, 2025
jukkahyv
left a comment
jukkahyv
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I think this would be a good change. No one uses Newtonsoft anymore.
Contributor
|
@AlexEngblom could we get this and the other PR merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified to use the faster System.Text.Json routines and remove the Newtonsoft dependency.