PR for IMDS Sigma Rule, Issue #514#1130
Open
jtega149 wants to merge 6 commits into
Open
Conversation
…add unit tests for new rule inside sigma_rule.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Sigma detection rule for outbound connections to the cloud Instance Metadata Service (
169.254.169.254) from processes that are not known legitimate metadata clients (MITRE T1552.005, medium severity).Changes:
rules/sigma/network/lnx_imds_access_from_non_metadata_client.ymlnetwork.outbound_connectevents to169.254.169.254cloud-init,ec2-metadata-collector,instance-controller,gcp-metadata-server, azure-metadata-monitorsigma_rule.rsnow honors Sigma filter blocks (selection and not filter) so allowlisted clients do not false-positiveComplements the existing
imds_ssrfRust detector; this exposes the same signal in the Sigma rule set.Type
Validation
make checkmake testmake scenario-qa— if this PR touches anything that could change incident / telegram / block volumesRisk
Spec 024 regression gate
If this PR changes a gate threshold, cooldown, responder behaviour, notification policy, or any code on the incident → decision → notification → block path, it can silently drift the volumes asserted in
testdata/scenarios/. Before merging:make scenario-qalocally; all 7 scenarios still pass (or I updated the matchingexpected.jsonenvelope and explained why in the PR body)Documentation
Module submission (fill in only for new modules)
Module ID:
my-moduleTier: open / premium
Checklist
modules/<id>/module.toml- valid TOML, all required fields present, kebab-case IDmodules/<id>/docs/README.md- has## Overview,## Configuration,## Securitysectionsmodules/<id>/tests/- at least one.rstest file (orbuiltin = truewith tests incrates/)[[rules]]entries haveauto_execute = false(default safe posture).arg()calls - no.arg(format!(...))interpolationdry_runbefore executing any privileged command[security].allowed_commandslists every binary the module invokesinnerwarden module validate --strict modules/<id>passes locallyCloses #514