chore: sync exchange proto types for per-market margin modes - #370
Open
ze97286 wants to merge 1 commit into
Open
chore: sync exchange proto types for per-market margin modes#370ze97286 wants to merge 1 commit into
ze97286 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR adds a subaccount market risk mode feature (message, store keys, genesis validation, and proto definitions), expands cross-margin parameters and validation, changes authz spend-limit gating logic to treat SpendLimit as optional, adds derivative order/fee-discount staking helpers, and deprecates several oracle types while removing oracle fields from peggy rate-limit messages. ChangesSubaccount Market Risk Mode Feature
Cross-Margin Parameters
Authz Spend-Limit Gating
Derivative Orders and Fee Discounts
Oracle Type Deprecation & Peggy Cleanup
Estimated code review effort: 4 (Complex) | ~75 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
chain/exchange/types/v2/derivative_orders.go (1)
47-75: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueOptional: fold
NewMarketOrderForLiquidationinto the partial variant to remove duplication.The two constructors are identical apart from the quantity argument;
NewMarketOrderForLiquidationcould delegate toNewMarketOrderForPartialLiquidation(position, position.Quantity, ...).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@chain/exchange/types/v2/derivative_orders.go` around lines 47 - 75, `NewMarketOrderForLiquidation` and `NewMarketOrderForPartialLiquidation` duplicate the same order construction logic, differing only in the quantity used. Update `NewMarketOrderForLiquidation` to delegate to `NewMarketOrderForPartialLiquidation` using `position.Quantity` for the close quantity, and keep all shared fields and order type selection centralized in the partial-liquidation constructor.chain/exchange/types/v2/fee_discounts.go (2)
128-147: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low valueLazy mutex init in
SetReadOnlyFeeDiscountRateis itself racy.If
c.readOnlyFeeDiscountMux == nil, two goroutines can each allocate a distinct mutex before either takes the lock, defeating the synchronization. SinceNewFeeDiscountConfigalways initializes the mux, this branch only matters for configs built outside the constructor. Prefer requiring construction viaNewFeeDiscountConfig(orsync.Once) rather than lazy init under contention.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@chain/exchange/types/v2/fee_discounts.go` around lines 128 - 147, The lazy initialization in SetReadOnlyFeeDiscountRate is racy because multiple goroutines can create different readOnlyFeeDiscountMux instances before locking. Update FeeDiscountConfig so the mutex is guaranteed to be initialized through NewFeeDiscountConfig (and avoid nil-branch lazy init here), or protect one-time initialization with sync.Once; keep the SetReadOnlyFeeDiscountRate and readOnlyFeeDiscountRates access synchronized on the single shared mutex.
241-268: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueOptional: reduce duplication with
NewFeeDiscountStakingInfo.This constructor repeats the full map/mutex initialization block of
NewFeeDiscountStakingInfo, differing only in field sources. A shared private helper for the empty-maps+muxes skeleton would keep the two in sync as fields evolve.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@chain/exchange/types/v2/fee_discounts.go` around lines 241 - 268, NewFeeDiscountStakingInfoForReadOnlyLookup duplicates the empty map and mutex setup from NewFeeDiscountStakingInfo, which risks the two constructors drifting apart. Extract the shared initialization for FeeDiscountStakingInfo into a private helper and have both constructors call it, then apply only their differing field assignments (for example Schedule, timestamps, and cache references) in each constructor.proto/injective/peggy/v1/rate_limit.proto (1)
36-37: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winReserve field number 8 on persisted
RateLimit.
token_oracle_type(field 8) was removed but not reserved.RateLimitis persisted chain state, so re-assigning tag 8 to a new field later would misdecode already-stored records. Addreserved 8;(and the field name) unless the upstreaminjective-coretree deliberately leaves it open.♻️ Suggested reservation
// transfers that occurred within the sliding window repeated BridgeTransfer transfers = 7 [ deprecated = true ]; + + reserved 8; + reserved "token_oracle_type"; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@proto/injective/peggy/v1/rate_limit.proto` around lines 36 - 37, The persisted RateLimit proto still has an unused tag 8 that was previously assigned to token_oracle_type, so it should be reserved to prevent future reuse from misdecoding stored chain state. Update the RateLimit message in rate_limit.proto to add a reservation for field number 8 and the removed field name token_oracle_type, keeping the existing BridgeTransfer transfers definition unchanged. Use the RateLimit message definition as the anchor for this change.proto/injective/peggy/v1/msgs.proto (1)
404-405: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winReserve the removed field numbers and names.
token_oracle_typeandnew_token_oracle_typewere removed withoutreserveddeclarations, so their tags can be reused later with an incompatible type and break wire compatibility.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@proto/injective/peggy/v1/msgs.proto` around lines 404 - 405, The Peggy v1 message definition is missing protobuf reservations for fields that were removed, which can allow their tags and names to be reused incompatibly. Update the affected message in msgs.proto to add reserved declarations for the removed symbols token_oracle_type and new_token_oracle_type, including both their field numbers and names, so future edits to this message remain wire-compatible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chain/exchange/types/v2/genesis.go`:
- Around line 129-155: The genesis validation helpers for spot orderbooks and
settlement data are using raw MarketId strings, unlike the risk mode path that
normalizes hex IDs. Update spotMarketIDs, derivativeMarketByID, binaryMarketIDs,
validatedExpiryInfoMarketIDs, and validateScheduledSettlementMarkerID to store
and compare keys using the same common.HexToHash(id).Hex() normalization, and
make the spotOrderbook/settlement lookups in validateSpotOrderbookMarkets use
the normalized form so mixed-case hex IDs validate and duplicate detection stays
consistent.
In `@proto/injective/exchange/v2/query.proto`:
- Around line 1443-1486: Update the stale comment on the
`MsgLiquidateCrossMarginPool` request in `query.proto` so it matches the
graduated selective liquidation behavior described in `tx.proto` instead of
saying the message closes all positions atomically. Keep the `reserved 16`
rationale aligned with the current design: explain that this field is no longer
needed because liquidation now closes only enough positions to restore health,
and reference the nearby snapshot fields (`ratcheted_maintenance_margin_total`,
`cross_margin_util_ratio`, `position_order_lock_requirement`,
`non_position_order_lock_requirement`) as the supporting context.
---
Nitpick comments:
In `@chain/exchange/types/v2/derivative_orders.go`:
- Around line 47-75: `NewMarketOrderForLiquidation` and
`NewMarketOrderForPartialLiquidation` duplicate the same order construction
logic, differing only in the quantity used. Update
`NewMarketOrderForLiquidation` to delegate to
`NewMarketOrderForPartialLiquidation` using `position.Quantity` for the close
quantity, and keep all shared fields and order type selection centralized in the
partial-liquidation constructor.
In `@chain/exchange/types/v2/fee_discounts.go`:
- Around line 128-147: The lazy initialization in SetReadOnlyFeeDiscountRate is
racy because multiple goroutines can create different readOnlyFeeDiscountMux
instances before locking. Update FeeDiscountConfig so the mutex is guaranteed to
be initialized through NewFeeDiscountConfig (and avoid nil-branch lazy init
here), or protect one-time initialization with sync.Once; keep the
SetReadOnlyFeeDiscountRate and readOnlyFeeDiscountRates access synchronized on
the single shared mutex.
- Around line 241-268: NewFeeDiscountStakingInfoForReadOnlyLookup duplicates the
empty map and mutex setup from NewFeeDiscountStakingInfo, which risks the two
constructors drifting apart. Extract the shared initialization for
FeeDiscountStakingInfo into a private helper and have both constructors call it,
then apply only their differing field assignments (for example Schedule,
timestamps, and cache references) in each constructor.
In `@proto/injective/peggy/v1/msgs.proto`:
- Around line 404-405: The Peggy v1 message definition is missing protobuf
reservations for fields that were removed, which can allow their tags and names
to be reused incompatibly. Update the affected message in msgs.proto to add
reserved declarations for the removed symbols token_oracle_type and
new_token_oracle_type, including both their field numbers and names, so future
edits to this message remain wire-compatible.
In `@proto/injective/peggy/v1/rate_limit.proto`:
- Around line 36-37: The persisted RateLimit proto still has an unused tag 8
that was previously assigned to token_oracle_type, so it should be reserved to
prevent future reuse from misdecoding stored chain state. Update the RateLimit
message in rate_limit.proto to add a reservation for field number 8 and the
removed field name token_oracle_type, keeping the existing BridgeTransfer
transfers definition unchanged. Use the RateLimit message definition as the
anchor for this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ebf89bb9-03ef-405b-963e-e7adbba69803
⛔ Files ignored due to path filters (10)
chain/exchange/types/v2/events.pb.gois excluded by!**/*.pb.gochain/exchange/types/v2/exchange.pb.gois excluded by!**/*.pb.gochain/exchange/types/v2/genesis.pb.gois excluded by!**/*.pb.gochain/exchange/types/v2/query.pb.gois excluded by!**/*.pb.gochain/exchange/types/v2/tx.pb.gois excluded by!**/*.pb.gochain/oracle/types/oracle.pb.gois excluded by!**/*.pb.gochain/peggy/types/msgs.pb.gois excluded by!**/*.pb.gochain/peggy/types/rate_limit.pb.gois excluded by!**/*.pb.gochain/stream/types/query.pb.gois excluded by!**/*.pb.gochain/stream/types/v2/query.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (24)
chain/exchange/types/authz_exchange_generic.gochain/exchange/types/errors.gochain/exchange/types/key.gochain/exchange/types/proposal.gochain/exchange/types/v2/authz_exchange_generic.gochain/exchange/types/v2/codec.gochain/exchange/types/v2/derivative.gochain/exchange/types/v2/derivative_orders.gochain/exchange/types/v2/fee_discounts.gochain/exchange/types/v2/genesis.gochain/exchange/types/v2/msgs.gochain/exchange/types/v2/params.gochain/exchange/types/v2/proposal.goinjective_data/chain_messages_list.jsonproto/injective/exchange/v2/events.protoproto/injective/exchange/v2/exchange.protoproto/injective/exchange/v2/genesis.protoproto/injective/exchange/v2/query.protoproto/injective/exchange/v2/tx.protoproto/injective/oracle/v1beta1/oracle.protoproto/injective/peggy/v1/msgs.protoproto/injective/peggy/v1/rate_limit.protoproto/injective/stream/v1beta1/query.protoproto/injective/stream/v2/query.proto
Comment on lines
+129
to
+155
| func (gs GenesisState) validateSpotOrderbookMarkets() error { | ||
| spotMarkets := gs.spotMarketIDs() | ||
| for i, orderbook := range gs.SpotOrderbook { | ||
| marketID := orderbook.MarketId | ||
| if !types.IsHexHash(marketID) { | ||
| return fmt.Errorf("spot_orderbook[%d]: invalid market_id %q", i, marketID) | ||
| } | ||
| if _, ok := spotMarkets[marketID]; !ok { | ||
| return fmt.Errorf("spot_orderbook[%d]: unknown market_id %s", i, marketID) | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (gs GenesisState) spotMarketIDs() map[string]struct{} { | ||
| markets := make(map[string]struct{}, len(gs.SpotMarkets)) | ||
| for _, market := range gs.SpotMarkets { | ||
| if market == nil { | ||
| continue | ||
| } | ||
| markets[market.MarketId] = struct{}{} | ||
| } | ||
|
|
||
| return markets | ||
| } | ||
|
|
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Normalize hex market IDs in spot orderbook and settlement validation maps for consistency with risk mode validation.
The new risk mode validation path (derivativeMarketIDs at line 123, validateMarketRiskModeRecord at line 80) normalizes market IDs via common.HexToHash(id).Hex(), and the duplicate-detection comment at lines 59-62 explicitly states this is required because IsHexHash accepts mixed-case hex. However, the also-new spot orderbook and settlement validation helpers build their lookup maps with raw market.MarketId strings:
spotMarketIDs()(line 150):markets[market.MarketId] = struct{}{}derivativeMarketByID()(line 183):markets[market.MarketId] = marketbinaryMarketIDs()(line 195):markets[market.MarketId] = struct{}{}validatedExpiryInfoMarketIDs()(line 207):expiryInfos[info.MarketId] = struct{}{}validateScheduledSettlementMarkerID(line 240):seen[marketID] = struct{}{}
This causes two classes of problems with mixed-case hex genesis input:
- False rejections — a spot orderbook or settlement marker referencing a market with different casing than its definition fails the
known market_idlookup. - False acceptances — duplicate settlement markers with mixed-case market IDs bypass duplicate detection, potentially allowing inconsistent genesis state.
🔧 Proposed fix: normalize all genesis market-ID map keys and lookups
Apply the same common.HexToHash(id).Hex() normalization used by derivativeMarketIDs():
func (gs GenesisState) spotMarketIDs() map[string]struct{} {
markets := make(map[string]struct{}, len(gs.SpotMarkets))
for _, market := range gs.SpotMarkets {
if market == nil {
continue
}
- markets[market.MarketId] = struct{}{}
+ markets[common.HexToHash(market.MarketId).Hex()] = struct{}{}
}
return markets
} func (gs GenesisState) derivativeMarketByID() map[string]*DerivativeMarket {
markets := make(map[string]*DerivativeMarket, len(gs.DerivativeMarkets))
for _, market := range gs.DerivativeMarkets {
if market == nil {
continue
}
- markets[market.MarketId] = market
+ markets[common.HexToHash(market.MarketId).Hex()] = market
}
return markets
} func (gs GenesisState) binaryMarketIDs() map[string]struct{} {
markets := make(map[string]struct{}, len(gs.BinaryOptionsMarkets))
for _, market := range gs.BinaryOptionsMarkets {
if market == nil {
continue
}
- markets[market.MarketId] = struct{}{}
+ markets[common.HexToHash(market.MarketId).Hex()] = struct{}{}
}
return markets
} func (gs GenesisState) validatedExpiryInfoMarketIDs() (map[string]struct{}, error) {
expiryInfos := make(map[string]struct{}, len(gs.ExpiryFuturesMarketInfoState))
for i, info := range gs.ExpiryFuturesMarketInfoState {
if err := validateExpiryInfoState(i, info); err != nil {
return nil, err
}
- expiryInfos[info.MarketId] = struct{}{}
+ expiryInfos[common.HexToHash(info.MarketId).Hex()] = struct{}{}
}
return expiryInfos, nil
}Then update all lookups and duplicate detection to normalize the query key:
func (gs GenesisState) validateSpotOrderbookMarkets() error {
spotMarkets := gs.spotMarketIDs()
for i, orderbook := range gs.SpotOrderbook {
marketID := orderbook.MarketId
if !types.IsHexHash(marketID) {
return fmt.Errorf("spot_orderbook[%d]: invalid market_id %q", i, marketID)
}
- if _, ok := spotMarkets[marketID]; !ok {
+ if _, ok := spotMarkets[common.HexToHash(marketID).Hex()]; !ok {
return fmt.Errorf("spot_orderbook[%d]: unknown market_id %s", i, marketID)
}
}
return nil
} func validateScheduledSettlementMarkerID(
i int,
marker DerivativeMarketSettlementInfo,
seen map[string]struct{},
) error {
marketID := marker.MarketId
if !types.IsHexHash(marketID) {
return fmt.Errorf("derivative_market_settlement_scheduled[%d]: invalid market_id %q", i, marketID)
}
- if _, ok := seen[marketID]; ok {
+ normalizedID := common.HexToHash(marketID).Hex()
+ if _, ok := seen[normalizedID]; ok {
return fmt.Errorf("derivative_market_settlement_scheduled[%d]: duplicate market_id %s", i, marketID)
}
- seen[marketID] = struct{}{}
+ seen[normalizedID] = struct{}{}
return nil
} func validateScheduledSettlementMarkerMarket(
i int,
marker DerivativeMarketSettlementInfo,
derivativeMarkets map[string]*DerivativeMarket,
binaryMarkets map[string]struct{},
expiryInfos map[string]struct{},
) error {
marketID := marker.MarketId
- if derivativeMarket, ok := derivativeMarkets[marketID]; ok {
+ normalizedID := common.HexToHash(marketID).Hex()
+ if derivativeMarket, ok := derivativeMarkets[normalizedID]; ok {
return validateDerivativeSettlementMarker(i, marker, derivativeMarket, expiryInfos)
}
- if _, ok := binaryMarkets[marketID]; ok {
+ if _, ok := binaryMarkets[normalizedID]; ok {
return validateBinarySettlementMarker(i, marker)
}
return fmt.Errorf("derivative_market_settlement_scheduled[%d]: unknown market_id %s", i, marketID)
} func validateDerivativeSettlementMarker(
i int,
marker DerivativeMarketSettlementInfo,
market *DerivativeMarket,
expiryInfos map[string]struct{},
) error {
marketID := marker.MarketId
if market.IsTimeExpiry() {
- if _, hasInfo := expiryInfos[marketID]; !hasInfo {
+ if _, hasInfo := expiryInfos[common.HexToHash(marketID).Hex()]; !hasInfo {
return fmt.Errorf("derivative_market_settlement_scheduled[%d]: expiry market %s missing expiry info",
i, marketID)
}
} func validateExpiryInfoState(i int, info ExpiryFuturesMarketInfoState) error {
if !types.IsHexHash(info.MarketId) {
return fmt.Errorf("expiry_futures_market_info_state[%d]: invalid market_id %q", i, info.MarketId)
}
if info.MarketInfo == nil {
return fmt.Errorf("expiry_futures_market_info_state[%d]: missing market_info", i)
}
- if info.MarketInfo.MarketId != "" && info.MarketInfo.MarketId != info.MarketId {
+ if info.MarketInfo.MarketId != "" &&
+ common.HexToHash(info.MarketInfo.MarketId).Hex() != common.HexToHash(info.MarketId).Hex() {
return fmt.Errorf("expiry_futures_market_info_state[%d]: market_id mismatch %q != %q",
i, info.MarketInfo.MarketId, info.MarketId)
}Also applies to: 177-211, 228-243
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@chain/exchange/types/v2/genesis.go` around lines 129 - 155, The genesis
validation helpers for spot orderbooks and settlement data are using raw
MarketId strings, unlike the risk mode path that normalizes hex IDs. Update
spotMarketIDs, derivativeMarketByID, binaryMarketIDs,
validatedExpiryInfoMarketIDs, and validateScheduledSettlementMarkerID to store
and compare keys using the same common.HexToHash(id).Hex() normalization, and
make the spotOrderbook/settlement lookups in validateSpotOrderbookMarkets use
the normalized form so mixed-case hex IDs validate and duplicate detection stays
consistent.
Comment on lines
+1443
to
+1486
|
|
||
| // Ratcheted maintenance margin total: max(maintenance at current mark, | ||
| // maintenance at entry notional) summed across positions. This is the | ||
| // maintenance floor used in the cash-floor and withdrawable formulas, and is | ||
| // distinct from maintenance_margin_total. It is NOT derivable from the other | ||
| // response fields, so off-chain monitors need it to reconstruct the chain's | ||
| // admission / withdrawal predicates. | ||
| string ratcheted_maintenance_margin_total = 17 [ | ||
| (gogoproto.customtype) = "cosmossdk.io/math.LegacyDec", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
|
|
||
| // Cross-margin utilisation ratio applied to the cash floor (0 is the | ||
| // emergency halt on new risk-increasing actions). A module param, not | ||
| // recoverable from any other response field. | ||
| string cross_margin_util_ratio = 18 [ | ||
| (gogoproto.customtype) = "cosmossdk.io/math.LegacyDec", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
|
|
||
| // Position-side Order Lock Requirement bucket embedded in | ||
| // order_lock_requirement. This is the sum of max(position.Margin, 0), not the | ||
| // signed position_margin_total. It is exposed because negative-funded or | ||
| // mixed-sign position margins make the OLR split impossible to reconstruct | ||
| // from position_margin_total. | ||
| string position_order_lock_requirement = 19 [ | ||
| (gogoproto.customtype) = "cosmossdk.io/math.LegacyDec", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
|
|
||
| // Non-position Order Lock Requirement bucket used by the cash-floor formula. | ||
| // This is not generally max(order_lock_requirement - position_margin_total, | ||
| // 0) because position_margin_total is signed while the position-side OLR | ||
| // bucket floors each position margin at zero. Together with | ||
| // ratcheted_maintenance_margin_total, cross_margin_util_ratio, and the | ||
| // existing equity fields, monitors can derive fees_buffer | ||
| // (= quote_balance + position_margin_total + unrealized_pnl_effective - | ||
| // equity_admission), cash_floor_available, admission_available | ||
| // (= equity_admission - order_lock_requirement), available_for_new | ||
| // (= min(cash_floor_available, admission_available)), and withdrawable. | ||
| string non_position_order_lock_requirement = 20 [ | ||
| (gogoproto.customtype) = "cosmossdk.io/math.LegacyDec", | ||
| (gogoproto.nullable) = false | ||
| ]; |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Update stale MsgLiquidateCrossMarginPool comment at line 1441 to match graduated selective liquidation.
The adjacent comment at line 1441 states "MsgLiquidateCrossMarginPool closes all positions atomically," but tx.proto lines 1745–1747 now describe it as performing "graduated selective liquidation" that closes "only enough positions to restore health according to the configured target." The new snapshot fields 17–20 (ratcheted_maintenance_margin_total, cross_margin_util_ratio, position_order_lock_requirement, non_position_order_lock_requirement) directly support this graduated behavior, making the stale rationale for the reserved 16 field confusing.
The field 16 removal may still be correct (graduated liquidation doesn't need a canonical target market ID either), but the stated reason should be updated to reflect the current behavior.
📝 Proposed fix for stale comment
// Field 16 removed: canonical_liquidation_target_market_id is no longer
- // relevant — MsgLiquidateCrossMarginPool closes all positions atomically.
+ // relevant — MsgLiquidateCrossMarginPool performs graduated selective
+ // liquidation, closing only enough positions to restore health.
reserved 16;🧰 Tools
🪛 Buf (1.71.0)
[error] 1451-1451: cannot find gogoproto.customtype in this scope
(COMPILE)
[error] 1452-1452: cannot find gogoproto.nullable in this scope
(COMPILE)
[error] 1459-1459: cannot find gogoproto.customtype in this scope
(COMPILE)
[error] 1460-1460: cannot find gogoproto.nullable in this scope
(COMPILE)
[error] 1469-1469: cannot find gogoproto.customtype in this scope
(COMPILE)
[error] 1470-1470: cannot find gogoproto.nullable in this scope
(COMPILE)
[error] 1484-1484: cannot find gogoproto.customtype in this scope
(COMPILE)
[error] 1485-1485: cannot find gogoproto.nullable in this scope
(COMPILE)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@proto/injective/exchange/v2/query.proto` around lines 1443 - 1486, Update the
stale comment on the `MsgLiquidateCrossMarginPool` request in `query.proto` so
it matches the graduated selective liquidation behavior described in `tx.proto`
instead of saying the message closes all positions atomically. Keep the
`reserved 16` rationale aligned with the current design: explain that this field
is no longer needed because liquidation now closes only enough positions to
restore health, and reference the nearby snapshot fields
(`ratcheted_maintenance_margin_total`, `cross_margin_util_ratio`,
`position_order_lock_requirement`, `non_position_order_lock_requirement`) as the
supporting context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the generated exchange types from injective-core's hybrid margin branch (per-market margin modes on a single subaccount):
Tagged v1.61.0-cross-margin.8 for the interchaintest dependency in the core branch.
Summary by CodeRabbit
New Features
Bug Fixes
Chores