Update filter HTML encode Output Data.#12
Open
thewindghost wants to merge 1 commit intoInitRoot:masterv2from
Open
Update filter HTML encode Output Data.#12thewindghost wants to merge 1 commit intoInitRoot:masterv2from
thewindghost wants to merge 1 commit intoInitRoot:masterv2from
Conversation
Author
|
@InitRoot Hi you can see my PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I've been quite busy lately and haven't been able to update the HTML filter and open Pull Requests like you previously emailed me. Currently, this is my patch after testing; it actually re-encodes the HTML to protect against XSS attacks. Basically, I intended to suggest forcing output via .json or .txt files, but that would significantly reduce the usability of the log export functionality. Therefore, I'll suggest filtering right when it enters data into the log and mapped it.
Befor:
After:
