Conversation
likekangen
left a comment
There was a problem hiding this comment.
Review summary for PR #4 — Add additional Mac/Linux instructions to README
Thanks for the docs improvement. I checked out the PR locally and ran the project gates against the PR head.
Validation run locally:
python -m unittestusing the existing project venv: PASS, 52 testsscripts/check_shareable_repo.py --include-untracked: PASSscripts/check_tracked_sensitive_names.py: PASSgit diff --check origin/main...HEAD: PASS
Review notes:
- The added macOS/Linux commands are useful and match the existing project layout.
- The README capitalization cleanups are harmless.
- GitHub Actions currently shows “Action required” for this PR from the public Actions page, so I would wait for the workflow permission/check state to be resolved before merging.
Recommendation: approve after the GitHub Actions “Action required” state is resolved, or merge manually if maintainers have independently verified the checks and understand why Actions did not run.
likekangen
left a comment
There was a problem hiding this comment.
Approving based on local validation and the small documentation-only scope.
Local validation already passed:
python -m unittest: PASS, 52 testsscripts/check_shareable_repo.py --include-untracked: PASSscripts/check_tracked_sensitive_names.py: PASSgit diff --check origin/main...HEAD: PASS
gh pr checks currently reports no checks on the branch, so this approval is based on the local verification above.
|
Maintainer note: this PR is ready to merge from my side.
I attempted to merge, but the |
|
Incorporated in #8, now merged into main: the README includes complete macOS/Linux setup, validation, and run commands. Thank you for the documentation improvement. |
|
Awesome. Thanks @Ingar30 for keeping improving this cool tool! |
No description provided.