Skip to content

Add additional Mac/Linux instructions to readme - #4

Closed
lukestein wants to merge 1 commit into
Ingar30:mainfrom
lukestein:main
Closed

lukestein wants to merge 1 commit into
Ingar30:mainfrom
lukestein:main

Conversation

@lukestein

Copy link
Copy Markdown

No description provided.

@likekangen likekangen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary for PR #4 — Add additional Mac/Linux instructions to README

Thanks for the docs improvement. I checked out the PR locally and ran the project gates against the PR head.

Validation run locally:

  • python -m unittest using the existing project venv: PASS, 52 tests
  • scripts/check_shareable_repo.py --include-untracked: PASS
  • scripts/check_tracked_sensitive_names.py: PASS
  • git diff --check origin/main...HEAD: PASS

Review notes:

  • The added macOS/Linux commands are useful and match the existing project layout.
  • The README capitalization cleanups are harmless.
  • GitHub Actions currently shows “Action required” for this PR from the public Actions page, so I would wait for the workflow permission/check state to be resolved before merging.

Recommendation: approve after the GitHub Actions “Action required” state is resolved, or merge manually if maintainers have independently verified the checks and understand why Actions did not run.

@likekangen likekangen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on local validation and the small documentation-only scope.

Local validation already passed:

  • python -m unittest: PASS, 52 tests
  • scripts/check_shareable_repo.py --include-untracked: PASS
  • scripts/check_tracked_sensitive_names.py: PASS
  • git diff --check origin/main...HEAD: PASS

gh pr checks currently reports no checks on the branch, so this approval is based on the local verification above.

@likekangen

Copy link
Copy Markdown

Maintainer note: this PR is ready to merge from my side.

  • Mergeable: yes
  • Scope: README documentation only
  • Local validation passed earlier:
    • python -m unittest — PASS, 52 tests
    • scripts/check_shareable_repo.py --include-untracked — PASS
    • scripts/check_tracked_sensitive_names.py — PASS
    • git diff --check — PASS

I attempted to merge, but the likekangen account does not have repository merge permission, so a maintainer needs to merge it.

@Ingar30

Ingar30 commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Incorporated in #8, now merged into main: the README includes complete macOS/Linux setup, validation, and run commands. Thank you for the documentation improvement.

@Ingar30 Ingar30 closed this Sep 2, 2026
@lukestein

Copy link
Copy Markdown
Author

Awesome. Thanks @Ingar30 for keeping improving this cool tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants