Open
Conversation
tevincent
force-pushed
the
base-home-screen
branch
from
ba072a3 to
42037f6
Compare
|
This PR/issue depends on:
|
tevincent
force-pushed
the
base-home-screen
branch
from
9a09d54 to
12aa8dd
Compare
tevincent
force-pushed
the
base-home-screen
branch
2 times, most recently
from
247fcd1 to
bc6422f
Compare
tevincent
force-pushed
the
bottom-bar
branch
3 times, most recently
from
18f674b to
cf0a7d4
Compare
# Conflicts: # app/src/main/kotlin/com/infomaniak/auth/ui/screen/main/MainScreen.kt
tevincent
force-pushed
the
base-home-screen
branch
from
fceea99 to
5ee18be
Compare
FabianDevel
requested changes
Feb 6, 2026
Comment on lines
31
to
32
|
|
||
|
|
app/src/main/kotlin/com/infomaniak/auth/ui/components/AuthenticatorFAB.kt
Outdated
Show resolved
Hide resolved
| FloatingActionButton( | ||
| onClick = onClick, | ||
| containerColor = AuthenticatorTheme.materialColors.primaryContainer, | ||
| shape = RoundedCornerShape(16.dp), |
There was a problem hiding this comment.
You can use our Dimens.largeCornerRadius
| .clickable(onClick = {}), | ||
| colors = CardDefaults.cardColors(containerColor = AuthenticatorTheme.colors.actionRequiredBackground), | ||
| border = BorderStroke(1.dp, AuthenticatorTheme.colors.actionRequiredBorder), | ||
| shape = RoundedCornerShape(16.dp), |
| Icon( | ||
| painter = painterResource(R.drawable.alert), | ||
| contentDescription = null, | ||
| tint = AuthenticatorTheme.colors.actionRequiredBorder, |
There was a problem hiding this comment.
It's a bit weird to have the color named border here.
Maybe we could have a name along the line of "actionRequiredPrimary" or "onActionRequiredSurface"
| Icon( | ||
| modifier = Modifier.padding(end = Margin.Mini), | ||
| painter = painterResource(id = account.securityLevel.iconResId), | ||
| contentDescription = null, |
There was a problem hiding this comment.
We should add a contentDescription for this icon, as there are no other way to know if the account is "blocked"
| @@ -0,0 +1,34 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Missing copyright for this and the others drawable
| android:pathData="M3.375,7.892C3.375,8.991 3.81,10.045 4.584,10.821C5.357,11.598 6.406,12.035 7.5,12.035C8.594,12.035 9.643,11.598 10.417,10.821C11.19,10.045 11.625,8.991 11.625,7.892C11.625,6.794 11.19,5.74 10.417,4.963C9.643,4.186 8.594,3.75 7.5,3.75C6.406,3.75 5.357,4.186 4.584,4.963C3.81,5.74 3.375,6.794 3.375,7.892Z" | ||
| android:strokeLineJoin="round" | ||
| android:strokeWidth="1.5" | ||
| android:fillColor="#00000000" |
| @@ -0,0 +1,9 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
I think to better follow the icon naming guidelines, it should be "shield_bang" or "shield_exclamation_mark"
| <string name="appAccessIsSecure">Der Zugriff auf Authenticator ist sicher</string> | ||
| <string name="authorizationCodeTitle">Ihr Autorisierungscode</string> | ||
| <string name="autoCloseTitle">Diese Information schliesst sich automatisch nach 15 Sekunden.</string> | ||
| <string name="avatarContentDescription">Avatar du compte</string> |
There was a problem hiding this comment.
This string is in french for all languages
Co-authored-by: Fabian Devel <fabian.devel@infomaniak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on Infomaniak/android-core#681 #24