Skip to content

Run WordPress Plugin Check in pull requests - #579

Merged
leopiccionia merged 4 commits into
InfoAmazonia:developfrom
bwstefano:codex/plugin-check-pr-gate
Jun 8, 2026
Merged

leopiccionia merged 4 commits into
InfoAmazonia:developfrom
bwstefano:codex/plugin-check-pr-gate

Conversation

@bwstefano

@bwstefano bwstefano commented May 21, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR promotes the official WordPress Plugin Check action from release-only validation to normal pull request and push validation.

Changes

  • Adds .github/workflows/plugin-check.yml for pull requests, pushes, and manual runs.
  • Builds release assets before staging src/ as a jeo/ plugin directory.
  • Runs wordpress/plugin-check-action@v1 against the staged plugin tree.
  • Removes the custom scripts/check-wporg-compliance.mjs script and npm script.
  • Keeps scripts/patch-build-compliance.mjs, because it still patches generated build artifacts before Plugin Check sees them.

Dependency

This PR is based directly on develop and does not depend on #576.

Validation

  • git diff --check upstream/develop..codex/plugin-check-pr-gate
  • GitHub Actions should provide the authoritative Plugin Check validation.

@bwstefano bwstefano added this to the 3.0 milestone May 21, 2026
@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch from acacffe to 6992b6a Compare May 21, 2026 18:13
Co-authored-by: Codex <codex@openai.com>
@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch from 6992b6a to d469df1 Compare May 21, 2026 18:55
@leopiccionia
leopiccionia marked this pull request as ready for review June 2, 2026 18:49
@leopiccionia
leopiccionia self-requested a review June 3, 2026 21:38

@leopiccionia leopiccionia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O script não parece rodar corretamente em CI.

@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch from fc141f5 to e7fd804 Compare June 8, 2026 18:26
@leopiccionia

Copy link
Copy Markdown
Collaborator

I cancelled the previous job manually, as it didn't timeout.

@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch 3 times, most recently from b23d5d9 to 482134d Compare June 8, 2026 18:41
@bwstefano

Copy link
Copy Markdown
Member Author

@leopiccionia, obrigado por ter feito esta proposta. A ideia faz sentido, mas reparei que, na execução mais recente depois da sua proposta, ela ainda não resolve o problema: o CI passa a falhar com service "cli" is not running.

Eu chequei com o Codex e o diagnóstico foi que o problema é que esse npx wp-env start inicia um ambiente genérico antes da wordpress/plugin-check-action criar o .wp-env.json dela e preparar o ambiente real do Plugin Check. Além disso, a action já tenta gerenciar o wp-env internamente, então ficamos com dois fluxos competindo.

Estou vendo uma forma de corrigir. Já te aviso.

@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch from 482134d to 45aebee Compare June 8, 2026 18:51
Replace the plugin-check-action/wp-env orchestration with an explicit WP-CLI WordPress install backed by the workflow MySQL service.

Keep the staged plugin build and Plugin Check command, and remove @wordpress/env from project devDependencies so CI does not depend on a project-level wp-env install.

Co-authored-by: Codex <codex@openai.com>
@bwstefano
bwstefano force-pushed the codex/plugin-check-pr-gate branch from 45aebee to 23983d8 Compare June 8, 2026 18:54
@leopiccionia
leopiccionia merged commit d713414 into InfoAmazonia:develop Jun 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants